Skip to content

Improve default privacy mode#113

Merged
Vadman97 merged 5 commits into
masterfrom
spenny/improve-default-privacy-mode
Nov 28, 2023
Merged

Improve default privacy mode#113
Vadman97 merged 5 commits into
masterfrom
spenny/improve-default-privacy-mode

Conversation

@SpennyNDaJets

@SpennyNDaJets SpennyNDaJets commented Nov 22, 2023

Copy link
Copy Markdown
Contributor
  • More strictly obfuscate inputs in default privacy mode.
  • Allow inputs and text to record despite matching regex by passing in data-hl-record attribute
  • Update regex expressions to use space character (\s) correctly

Implemented in monolith here: highlight/highlight#7200

@SpennyNDaJets SpennyNDaJets linked an issue Nov 22, 2023 that may be closed by this pull request
@SpennyNDaJets SpennyNDaJets requested review from a team, Vadman97 and deltaepsilon and removed request for a team November 22, 2023 21:32
@SpennyNDaJets

Copy link
Copy Markdown
Contributor Author

Apply format changes is reverting changes to regex 😵
de0769a

@Vadman97

Copy link
Copy Markdown
Member

looks good @SpennyNDaJets ! we can force merge the correct regex to main if needed

@SpennyNDaJets

Copy link
Copy Markdown
Contributor Author

looks good @SpennyNDaJets ! we can force merge the correct regex to main if needed

Sounds good, I was able to fix with the ignore prettier comment. Just waiting on confirmation that this would resolve concerns

@Vadman97 Vadman97 merged commit e1f0f31 into master Nov 28, 2023
Vadman97 pushed a commit that referenced this pull request Jan 30, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Mar 4, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Mar 5, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Mar 5, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Apr 16, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Apr 17, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Jun 25, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Jun 25, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Aug 5, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Aug 5, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Aug 5, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Aug 26, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Sep 3, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Sep 9, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Sep 18, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Oct 9, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Oct 9, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Oct 15, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Oct 15, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Oct 29, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Oct 29, 2024
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Mar 20, 2025
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Vadman97 pushed a commit that referenced this pull request Mar 21, 2025
- More strictly obfuscate inputs in default privacy mode.
- Allow inputs and text to record despite matching regex by passing in
`data-hl-record` attribute
- Update regex expressions to use space character (`\s`) correctly

Implemented in monolith here:
highlight/highlight#7200

---------

Co-authored-by: SpennyNDaJets <SpennyNDaJets@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Under obfuscating on default privacy mode

2 participants