Skip to content

Support cipher chacha20-poly1305@openssh.com#682

Merged
hierynomus merged 2 commits intohierynomus:masterfrom
hpoettker:chacha
Apr 20, 2021
Merged

Support cipher chacha20-poly1305@openssh.com#682
hierynomus merged 2 commits intohierynomus:masterfrom
hpoettker:chacha

Conversation

@hpoettker
Copy link
Copy Markdown
Contributor

Resolves #629.

@hpoettker hpoettker requested a review from hierynomus as a code owner April 19, 2021 21:30
Copy link
Copy Markdown
Contributor

@vladimirlagunov vladimirlagunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a very important feature! Thanks for implementing it!

Comment thread src/main/java/com/hierynomus/sshj/transport/cipher/ChachaPolyCipher.java Outdated
@hierynomus hierynomus merged commit 16db036 into hierynomus:master Apr 20, 2021
@hierynomus
Copy link
Copy Markdown
Owner

Thanks for the PR, I fixed the comment @vladimirlagunov had, and merged it.

@hpoettker hpoettker deleted the chacha branch April 20, 2021 16:16
@dkocher
Copy link
Copy Markdown
Contributor

dkocher commented Apr 27, 2021

Wouldn't want you add this to the default configuration in DefaultConfig?

@hierynomus
Copy link
Copy Markdown
Owner

Thanks @dkocher, indeed, fixed on master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding support for chacha20-poly1305@openssh.com

4 participants