Skip to content

test(plugin): prove verification lifecycle end to end - #286

Merged
hffmnnj merged 5 commits into
feat/write-tool-contractsfrom
feat/acceptance-wiring
Aug 3, 2026
Merged

hffmnnj merged 5 commits into
feat/write-tool-contractsfrom
feat/acceptance-wiring

Conversation

@hffmnnj

@hffmnnj hffmnnj commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

Adds end-to-end proof that staged verification is registered, enforced, remediated, and surfaced in the final audit. Aligns repository documentation with the implemented lifecycle and confirms all new modules are reachable.

Changes

  • Exercise V1 and V2 reviewer registration through real production seams
  • Verify execution-stage permissions, completion gating, remediation, and progression
  • Verify acceptance-stage permissions and append-only audit visibility
  • Document the staged gate, reviewer ownership, current evidence semantics, and role counts
  • Complete an import, registration, discovery, and skipped-test wiring audit

Testing

  • Full plugin suite: 2606 passed, 0 failed across 125 files
  • Integration scenario: 8 passed, 0 failed
  • Build: 291 modules bundled
  • TypeScript typecheck: clean
  • Diff and skipped-test checks: clean

Lint note

The changed files are clean under the package configuration. The package command still reports 10 errors and 17 warnings that exactly match the parent branch baseline; this is recorded as an explicit skip rather than a pass.

Notes

Depends on #285.

hffmnnj added 5 commits August 3, 2026 13:05
… (W5.T1)

Single integration test file wires the seams that unit tests already
cover in isolation through their real production entry points:
- goop-wave-verifier registration via the V1 config hook and the V2
  registerHooksV2 agent/catalog transform adapter (shared AGENT_ROLES
  path)
- the real merged tool.execute.before guard chain (createHooks +
  DEFAULT_HOOK_FACTORIES) blocking/permitting goop-verifier and
  goop-wave-verifier by phase
- goop_write_wave's wave-completion verification gate: zero rows and a
  failing row both block completion; a later pass row for the same
  check_name supersedes it (append-only, latest-per-check)
- the real auto-progression hook advancing execute -> accept once the
  final wave carries verification evidence
- goop_acceptance_audit surfacing the append-only fail+pass history

Covers MH2, MH4, MH5, MH7.

Verification: rtk proxy bun test packages/opencode-plugin/ --bail=3
--timeout=10000 (2606 pass, 0 fail); rtk proxy bun run --cwd
packages/opencode-plugin typecheck (clean); focused biome check on the
new file (clean).
… test

Wave 5 Task 3 wiring/quality-gate check: lint diff against the Wave 4
base (1a9ed89) isolated exactly one net-new regression introduced by
this workflow — a formatter-only violation in
stage-gating.integration.test.ts (added in W5.T1, a4b0eb1). Applied
`biome format --write` scoped to that single file only; whitespace-only,
behavior-preserving. Post-fix lint diagnostics (10 errors / 17 warnings)
now match the Wave 4 baseline file-and-rule set exactly, confirming no
lint regression remains from this workflow. Remaining baseline errors
belong to files this workflow never touched (prompt-audit/report.ts,
continuation-prompt.test.ts, system-transform.test.ts) or were already
present at the Wave 4 boundary, and are out of this task's scope.
…config

Convert tab indentation to Biome's configured 2-space style and collapse
signatures/calls that fit within lineWidth:100 in
verifier-stage.ts and verifier-stage.test.ts. Formatting-only; no token,
type, test, or behavior change. Removes the two workflow-owned lint
diagnostics blocking the acceptance gate; unrelated baseline lint debt in
other modules remains classified as skip.
@hffmnnj
hffmnnj merged commit 0c64c3b into feat/write-tool-contracts Aug 3, 2026
@hffmnnj
hffmnnj deleted the feat/acceptance-wiring branch August 3, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant