Repository navigation
test(plugin): prove verification lifecycle end to end - #286
Merged
Merged
Conversation
… (W5.T1) Single integration test file wires the seams that unit tests already cover in isolation through their real production entry points: - goop-wave-verifier registration via the V1 config hook and the V2 registerHooksV2 agent/catalog transform adapter (shared AGENT_ROLES path) - the real merged tool.execute.before guard chain (createHooks + DEFAULT_HOOK_FACTORIES) blocking/permitting goop-verifier and goop-wave-verifier by phase - goop_write_wave's wave-completion verification gate: zero rows and a failing row both block completion; a later pass row for the same check_name supersedes it (append-only, latest-per-check) - the real auto-progression hook advancing execute -> accept once the final wave carries verification evidence - goop_acceptance_audit surfacing the append-only fail+pass history Covers MH2, MH4, MH5, MH7. Verification: rtk proxy bun test packages/opencode-plugin/ --bail=3 --timeout=10000 (2606 pass, 0 fail); rtk proxy bun run --cwd packages/opencode-plugin typecheck (clean); focused biome check on the new file (clean).
… test Wave 5 Task 3 wiring/quality-gate check: lint diff against the Wave 4 base (1a9ed89) isolated exactly one net-new regression introduced by this workflow — a formatter-only violation in stage-gating.integration.test.ts (added in W5.T1, a4b0eb1). Applied `biome format --write` scoped to that single file only; whitespace-only, behavior-preserving. Post-fix lint diagnostics (10 errors / 17 warnings) now match the Wave 4 baseline file-and-rule set exactly, confirming no lint regression remains from this workflow. Remaining baseline errors belong to files this workflow never touched (prompt-audit/report.ts, continuation-prompt.test.ts, system-transform.test.ts) or were already present at the Wave 4 boundary, and are out of this task's scope.
…config Convert tab indentation to Biome's configured 2-space style and collapse signatures/calls that fit within lineWidth:100 in verifier-stage.ts and verifier-stage.test.ts. Formatting-only; no token, type, test, or behavior change. Removes the two workflow-owned lint diagnostics blocking the acceptance gate; unrelated baseline lint debt in other modules remains classified as skip.
… package biome config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end proof that staged verification is registered, enforced, remediated, and surfaced in the final audit. Aligns repository documentation with the implemented lifecycle and confirms all new modules are reachable.
Changes
Testing
Lint note
The changed files are clean under the package configuration. The package command still reports 10 errors and 17 warnings that exactly match the parent branch baseline; this is recorded as an explicit skip rather than a pass.
Notes
Depends on #285.