Repository navigation
fix(check): mark a contrast finding by its severity and quote its text - #7752
Open
wonjangcloud9 wants to merge 1 commit into
Open
wonjangcloud9 wants to merge 1 commit into
wonjangcloud9 wants to merge 1 commit into
Conversation
wonjangcloud9
force-pushed
the
fix/check-contrast-severity-icon
branch
from
November 15, 2026 08:36
cb31417 to
7b2d037
Compare
Contributor
Author
|
The commit here was unsigned, which |
The Contrast section printed every finding with the error mark, so a failure seen at a single sample (a warning) read as "✗ ... 0 error(s), 1 warning(s)". It now uses the same severity icon as the other sections. A finding on an element without an id is named by an nth-of-type path, which does not say which text failed. The line now quotes the text the audit judged, as `validate` already does. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
Author
|
Rebased again onto On it: |
wonjangcloud9
force-pushed
the
fix/check-contrast-severity-icon
branch
from
November 15, 2026 09:45
7b2d037 to
344d3f6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
check's Contrast section now marks each finding with its own severity (⚠for a warning,✗for an error) and quotes the text it judged.Why
A long-form video had a number card whose text passed through a low-contrast colour at one sample.
check(0.9.43) printed:Two things made this hard to act on:
✗, and the count line under it says0 error(s), 1 warning(s).buildContrastResultsdemotes a failure seen at a single sample to a warning, butprintContrastSectionhardcodesc.error("✗"). Every other section goes throughfindingIcon.nth-of-typepath. The finding already carries the text (text, capped at 50 characters by the audit), andvalidateprints it, butcheckdid not.Related work
How
packages/cli/src/commands/check.ts,printContrastSection: the mark comes fromfindingIcon(finding), and the line adds the dimmed, quotedfinding.textafter the selector when there is one. The JSON report is unchanged.Test plan
Unit (
packages/cli/src/commands/check.test.ts): a new case prints a report with one warning and one error contrast finding and expects⚠(and no✗) on the warning's line,✗on the error's line, and both lines found by their quoted text. On main (29533f63) with the fix stashed it fails withexpected '' to contain '⚠'. With the fix,check.test.tspasses 200 tests.tsc --noEmit, oxlint and oxfmt are clean.Real CLI on a minimal project (the blank template with a row of two id-less
<div>s, the second tweening from#3a3a3ato#ffffffat 2.4 s),hyperframes check --no-cache:🤖 Generated with Claude Code