Skip to content

fix conversion from IpAddress::Ipv4 to in_addr#1207

Merged
mkroening merged 2 commits intohermit-os:mainfrom
stlankes:peer
May 19, 2024
Merged

fix conversion from IpAddress::Ipv4 to in_addr#1207
mkroening merged 2 commits intohermit-os:mainfrom
stlankes:peer

Conversation

@stlankes
Copy link
Copy Markdown
Contributor

IpAddress::Ipv4 contains alreads the IP address in big-endian formt. => no byte swapping needed

With these changes, the demo httpd shows the correct address of the client.

stlankes added 2 commits May 19, 2024 17:09
IpAddress::Ipv4 contains alreads the IP address in big-endian formt.
=> no byte swapping needed

With these changes, the demo httpd shows the correct address of
the client.
Copy link
Copy Markdown
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's right. 👍

@mkroening mkroening enabled auto-merge May 19, 2024 15:24
@mkroening mkroening added this pull request to the merge queue May 19, 2024
Merged via the queue into hermit-os:main with commit 716ee54 May 19, 2024
@stlankes stlankes deleted the peer branch May 19, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants