Skip to content

chore: hold ratatui updates until kana rendering is fixed - #4953

Merged
ogulcancelik merged 1 commit into
masterfrom
chore/dependabot-hold-ratatui
Oct 5, 2026
Merged

ogulcancelik merged 1 commit into
masterfrom
chore/dependabot-hold-ratatui

Conversation

@ogulcancelik

Copy link
Copy Markdown
Collaborator

ratatui 0.30.1+ diffs a halfwidth kana + voiced mark as two columns, so the server's CursorTrackingBackend replay blanks the voiced mark (caught by render_keeps_halfwidth_katakana_voiced_tail_empty in #4946 and again in #4948). Ignore ratatui >0.30.0 in Dependabot so the monthly group stops failing on it; lift this once the render path handles the new diff.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c5637286-b97a-4204-9ee7-99b9dc607425
📥 Commits

Reviewing files that changed from the base of the PR and between b977116 and a9de160.

📒 Files selected for processing (1)
  • .github/dependabot.yml
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kangal-bot

Copy link
Copy Markdown
Collaborator

@coderabbitai review
@greptileai

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ogulcancelik
ogulcancelik merged commit b064806 into master Oct 5, 2026
7 of 8 checks passed
@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Holds back a UI library update temporarily.

The PR appears safe to merge.

Summary

The PR excludes ratatui versions above 0.30.0 from monthly Dependabot Cargo updates while the halfwidth-kana rendering regression remains unresolved.

  • The rule matches the direct dependency currently locked at 0.30.0.

Reviews (1) · Last reviewed commit: "chore: hold ratatui updates until kana r..."

@ogulcancelik
ogulcancelik deleted the chore/dependabot-hold-ratatui branch October 7, 2026 19:36
maciejul pushed a commit to maciejul/herdr-supercharged that referenced this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants