Repository navigation
Fix the Fable review findings for the 80a2351fcb sync - #289
Merged
Merged
Conversation
- Mark the two seam holes the sync left unmarked: ws.ts's refresh skips host-secret invalidation (pingdotgg#27746), and client-runtime's reconcilePlatform applies every reconcile (pingdotgg#26511). - coder-only.md: list the marked browser-test adaptations and the two uncarried upstream browser tests, add PeerMcpClient.test.ts to the uncarried peer tests, describe pingdotgg#27847's npm view version lookup, drop two references to test files that no longer exist, and recheck the GitLabCli fixes against 80a2351. - sync-resolve-deleted.mjs: cover the GitHub star prompt and guests' hostImageUrl.ts, and put each comment beside its entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #288. A three-reviewer Fable 5.1 review (server, web/client-runtime, seams/tooling) found no high-severity issues, no merge losses, and no boundary problems. This PR fixes the small findings:
Coder:markers at two seam holes:ws.tsserver.refreshProviders(no host-secret invalidation, feat(server): read Bitbucket and GitCafe credentials from a secret provider pingdotgg/t3code#27746) and client-runtimereconcilePlatform(no fix(client-runtime): idle clients stop tracing unchanged platform registrations pingdotgg/t3code#26511 skip).ProviderModelPicker.browser/ChatView.browsertests; addsPeerMcpClient.test.tsto the uncarried peer tests; describes fix(updates): version checks respect your configured npm registry pingdotgg/t3code#27847'snpm viewversion lookup; drops two references to deleted test files; rechecks the GitLabCli fixes against 80a2351 (upstream still has the bugs).sync-resolve-deleted.mjs: coversGitHubStarPromptandhostImageUrl.ts; puts each comment beside its entries.Left as is: upstream's "deleted from T3 Code" project-removal text (several web strings already say "T3 Code"); upstream's pingdotgg#26511 registry tests (they need the cut PR-routing permissions and persisted registrations); unmarked drift that predates this sync (
useComposerResume,useThreadLifecycle, and five server files).Verification:
pnpm typecheck:server, client-runtime typecheck,ws.test.ts,registry.test.ts,test:knip,vp fmt. The code changes are comments only.🤖 Generated with Claude Code