Repository navigation
Add an unused-locals check to the sync checklist - #225
Merged
Merged
Conversation
Knip does not report unused imports and locals, and the 688ee52 sync left about 50 behind from cut surfaces and split-module replays. sync.md section 6 now lists the fork-caused ones with tsc --noUnusedLocals, skipping names that upstream's own file leaves unused too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #224. Knip does not report unused imports and locals, and the 688ee52 sync left about 50 of them behind (from cut surfaces and from replaying the fork's delta into upstream's split modules), including a dead Claude worker.
docs/internals/sync.mdsection 6 now has a check: it runstsc --noUnusedLocalsover web, server, gateway, and every package, and prints only the unused names the fork caused, skipping any that upstream's own file at$SHAleaves unused too. Rerun it until it prints nothing.Verification
coder-only(after Fix the 688ee52f0e sync review findings #224) it prints nothing.BackgroundActivitySettings.tsxit reports exactly that import. The planted line was then reverted.vp fmt --checkpasses.🤖 Generated with Claude Code