Repository navigation
Format the files the cfafb4bb54 sync changed and check formatting on every sync - #196
Merged
Merged
Conversation
…ry sync Reviewing the cfafb4b sync, `vp fmt --check` over the 1,439 files it changed failed in ten. One failure is the sync's: deleting a pruned comment in ModelManifest.test.ts left a doubled blank line. The other nine (long lines in six files, blank-line residue in two, blank lines around a code fence in sync.md) were already in the fork, which never ran the formatter as part of a sync. All ten are the formatter's own output; no code changes. sync.md's verification step now ends with the formatter over the files the merge changed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from reviewing the cfafb4b sync (#195).
pnpm exec vp fmt --checkover the 1,439 files that sync changed fails in ten. One failure is the sync's own: deleting a pruned upstream comment inapps/server/src/provider/ModelManifest.test.tsleft a doubled blank line. The other nine were already in the fork before the sync (long lines in six files, blank-line residue inKeybindingsSettings.tsxandGitLabPullRequestProvider.test.ts, blank lines around a code fence indocs/internals/sync.md); the fork had never run the formatter as part of a sync, so they accumulated. Every change here is the formatter's own output.docs/internals/sync.mdsection 7 now ends with the formatter over the files the merge changed, so the next sync catches this class of residue.Verification:
vp fmt --checkpasses on all ten files;typecheck:server,typecheck:web, provider-pi and source-control-gitlab typechecks pass; the five reformatted test files pass (176 tests).🤖 Generated with Claude Code