Repository navigation
Converge workspace RPC handlers and streams onto upstream (phase d) - #106
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace RPC handlers had drifted from upstream in bootstrap sequencing, archive cleanup, clone identity, server-generated command attribution, and stream behavior. This converges
coderWs.ts, its stream contracts, and client consumers on upstream024d49520e, while preserving the helper stdio transport andCoderWsRpcGroupmethod set.Restores upstream shell/thread coalescing, persisted replay validation and byte limits, optional completion markers, capability negotiation, full
providerStatusesupdates, gated environment themes, and client reducers. Bootstrap now records setup activities and preparing state, archiving closes thread terminals, clone completion refreshes repository identity, and helper-generated commands use upstreamserver:IDs.Retained Coder seams are marked in code and documented in
docs/internals/coder-only.md: workspace-owned stdio execution, GitLab-only routing and write policy, bounded snapshots and file/media operations, API-only config, omitted telemetry/auth/desktop protocols, and memory-only idle retention capped at 24 threads / 64 MiB. Unsupported upstream methods remain omitted. Shared behavior follows upstream, including preserving a worktree after a non-cancel bootstrap failure.PR #105 is already merged; this PR explicitly targets
coder-only. Its latest GitLab write-probe header change is preserved by the clean merge preview. No code from Orchestrator v2 or later was used.Validation
024d49520e; live budget and thread coalescer match upstream byte-for-byte.git diff --checkpassed.88af4b2bdc, using real Git and an SSH-served bare remote with scripted glab/Claude: original harness has 30 observations with zero differences; extended harness has 16 observations with ten expected upstream-parity differences.The ten extended differences cover three config observations (advertised capabilities, themes excluded from snapshots, full provider arrays), three bootstrap observations (sequence 7 to 10 from additional durable records, upstream checkout/submodule progress, requested/started setup activities), buffered live events draining before the synchronization marker, terminal cleanup on archive, refreshed clone identity, and server command IDs/actors. The temporary baseline worktree was removed.
Live Windows gateway / Linux Coder smoke testing remains a follow-up. The separately queued cache-layer audit is outside this PR.