Skip to content

GitLab mr checkout: branch and force handling is unreachable #228

Open

Description

@henrychu04

GitLabCli.checkoutMergeRequest adds --branch and --force to glab mr checkout when its input sets branch or force (packages/source-control-gitlab/src/server/GitLabCli.ts, the Coder: notes on the input type and in checkoutMergeRequest).

No caller passes either field. The only path is GitManager → checkoutChangeRequest({ cwd, reference }) (apps/server/src/git/GitManager.ts), the same as upstream. So that part of the fork's change never runs and conflicts with upstream for nothing.

Fix: drop the branch field and the --branch and --force handling, and update the GitLab seam entry in docs/internals/coder-only.md. Keep the --repo <url> … -- <iid> selector, which is reachable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions