feat: Add converter for google_compute_image#9
Draft
google-labs-jules[bot] wants to merge 8 commits into
Draft
Conversation
Adds a Terraform Plan to CAI converter for the `google_compute_image` resource. This includes registering the pre-existing converter and adding a new test case to validate its functionality.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
hemantadil
reviewed
Oct 31, 2025
Comment on lines
+3
to
+6
| "ancestors": [ | ||
| "projects/{{.Project.Number}}", | ||
| "organizations/{{.OrgID}}" | ||
| ], |
Comment on lines
+56
to
+59
| "ancestors": [ | ||
| "projects/{{.Project.Number}}", | ||
| "organizations/{{.OrgID}}" | ||
| ], |
Owner
There was a problem hiding this comment.
This as well change to ancestry_path
Adds a Terraform Plan to CAI converter for the `google_compute_image` resource. This includes registering the pre-existing converter and adding a new test case to validate its functionality.
hemantadil
reviewed
Nov 1, 2025
| [ | ||
| { | ||
| "ancestry_path": "{{.Ancestry}}/project/{{.Provider.project}}", | ||
| "assetType": "compute.googleapis.com/Disk", |
Owner
There was a problem hiding this comment.
Suggested change
| "assetType": "compute.googleapis.com/Disk", | |
| "asset_type": "compute.googleapis.com/Disk", |
| "type": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a/diskTypes/pd-standard", | ||
| "zone": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a" | ||
| }, | ||
| "discoveryDocumentUri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", |
Owner
There was a problem hiding this comment.
Suggested change
| "discoveryDocumentUri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", | |
| "discovery_document_uri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", |
| "zone": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a" | ||
| }, | ||
| "discoveryDocumentUri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", | ||
| "discoveryName": "Disk", |
Owner
There was a problem hiding this comment.
Suggested change
| "discoveryName": "Disk", | |
| "discovery_name": "Disk", |
| }, | ||
| { | ||
| "ancestry_path": "{{.Ancestry}}/project/{{.Provider.project}}", | ||
| "assetType": "compute.googleapis.com/Image", |
Owner
There was a problem hiding this comment.
Suggested change
| "assetType": "compute.googleapis.com/Image", | |
| "asset_type": "compute.googleapis.com/Image", |
| "us-central1" | ||
| ] | ||
| }, | ||
| "discoveryDocumentUri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", |
Owner
There was a problem hiding this comment.
Suggested change
| "discoveryDocumentUri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", | |
| "discovery_document_uri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", |
| ] | ||
| }, | ||
| "discoveryDocumentUri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", | ||
| "discoveryName": "Image", |
Owner
There was a problem hiding this comment.
Suggested change
| "discoveryName": "Image", | |
| "discovery_name": "Image", |
Adds a Terraform Plan to CAI converter for the `google_compute_image` resource. This includes registering the pre-existing converter and adding a new test case to validate its functionality. This also addresses feedback from the pull request to use snake_case for JSON keys in the test file.
hemantadil
reviewed
Nov 1, 2025
| resource "google_compute_image" "gg-asset-42745-fa77" { | ||
| name = "gg-asset-42745-fa77" | ||
| project = "{{.Provider.project}}" | ||
| source_disk = google_compute_disk.gg-asset-42745-fa77.self_link |
Owner
There was a problem hiding this comment.
Suggested change
| source_disk = google_compute_disk.gg-asset-42745-fa77.self_link | |
| source_disk = "test-google-compute-disk-self-link" |
Comment on lines
+14
to
+23
| resource "google_compute_disk" "gg-asset-42745-fa77" { | ||
| name = "gg-asset-source-disk-42745-fa77" | ||
| image = "debian-cloud/debian-11" | ||
| size = 20 | ||
| type = "pd-standard" | ||
| zone = "us-central1-a" | ||
| labels = { | ||
| "gg-asset-key-42745-fa77" = "gg-asset-value-42745-fa77" | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| resource "google_compute_disk" "gg-asset-42745-fa77" { | |
| name = "gg-asset-source-disk-42745-fa77" | |
| image = "debian-cloud/debian-11" | |
| size = 20 | |
| type = "pd-standard" | |
| zone = "us-central1-a" | |
| labels = { | |
| "gg-asset-key-42745-fa77" = "gg-asset-value-42745-fa77" | |
| } | |
| } |
| ], | ||
| "name": "gg-asset-42745-fa77", | ||
| "selfLink": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/global/images/gg-asset-42745-fa77", | ||
| "sourceDisk": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a/disks/gg-asset-source-disk-42745-fa77", |
Owner
There was a problem hiding this comment.
Suggested change
| "sourceDisk": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a/disks/gg-asset-source-disk-42745-fa77", | |
| "sourceDisk": "test-google-compute-disk-self-link", |
Adds a Terraform Plan to CAI converter for the `google_compute_image` resource. This includes registering the pre-existing converter and adding a new test case to validate its functionality. This also addresses feedback from the pull request to use snake_case for JSON keys in the test file, and to remove the `google_compute_disk` resource from the test case.
hemantadil
reviewed
Nov 1, 2025
| resource "google_compute_image" "gg-asset-42745-fa77" { | ||
| name = "gg-asset-42745-fa77" | ||
| project = "{{.Provider.project}}" | ||
| source_disk = "test-google-compute-disk-self-link" |
Owner
There was a problem hiding this comment.
Suggested change
| source_disk = "test-google-compute-disk-self-link" | |
| source_disk = "https://www.googleapis.com/compute/v1/projects/debian-cloud/global/images/debian-11-bullseye-v20251014" |
| ], | ||
| "name": "gg-asset-42745-fa77", | ||
| "selfLink": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/global/images/gg-asset-42745-fa77", | ||
| "sourceDisk": "test-google-compute-disk-self-link", |
Owner
There was a problem hiding this comment.
Suggested change
| "sourceDisk": "test-google-compute-disk-self-link", | |
| "sourceDisk": "https://www.googleapis.com/compute/v1/projects/debian-cloud/global/images/debian-11-bullseye-v20251014", |
Adds a Terraform Plan to CAI converter for the `google_compute_image` resource. This includes registering the pre-existing converter and adding a new test case to validate its functionality. This also addresses feedback from the pull request to use snake_case for JSON keys in the test file, remove the `google_compute_disk` resource from the test case, and update the hardcoded `source_disk` value.
hemantadil
reviewed
Nov 1, 2025
| resource "google_compute_image" "gg-asset-42745-fa77" { | ||
| name = "gg-asset-42745-fa77" | ||
| project = "{{.Provider.project}}" | ||
| source_disk = "https://www.googleapis.com/compute/v1/projects/debian-cloud/global/images/debian-11-bullseye-v20251014" |
Owner
There was a problem hiding this comment.
Suggested change
| source_disk = "https://www.googleapis.com/compute/v1/projects/debian-cloud/global/images/debian-11-bullseye-v20251014" | |
| source_disk = "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a/disks/gg-asset-source-disk-42745-fa77" |
| ], | ||
| "name": "gg-asset-42745-fa77", | ||
| "selfLink": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/global/images/gg-asset-42745-fa77", | ||
| "sourceDisk": "https://www.googleapis.com/compute/v1/projects/debian-cloud/global/images/debian-11-bullseye-v20251014", |
Owner
There was a problem hiding this comment.
Suggested change
| "sourceDisk": "https://www.googleapis.com/compute/v1/projects/debian-cloud/global/images/debian-11-bullseye-v20251014", | |
| "sourceDisk": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a/disks/gg-asset-source-disk-42745-fa77", |
Adds a Terraform Plan to CAI converter for the `google_compute_image` resource. This includes registering the pre-existing converter and adding a new test case to validate its functionality. This also addresses feedback from the pull request to use snake_case for JSON keys in the test file, remove the `google_compute_disk` resource from the test case, and update the hardcoded `source_disk` value.
hemantadil
reviewed
Nov 1, 2025
| "discovery_document_uri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", | ||
| "discovery_name": "Image", | ||
| "location": "us-central1", | ||
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Project.Number}}", |
Owner
There was a problem hiding this comment.
Suggested change
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Project.Number}}", | |
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}", |
Comment on lines
+8
to
+10
| "architecture": "X86_64", | ||
| "archiveSizeBytes": "744988672", | ||
| "creationTimestamp": "2025-10-31T13:32:56.760-07:00", |
Owner
There was a problem hiding this comment.
Suggested change
| "architecture": "X86_64", | |
| "archiveSizeBytes": "744988672", | |
| "creationTimestamp": "2025-10-31T13:32:56.760-07:00", |
| "archiveSizeBytes": "744988672", | ||
| "creationTimestamp": "2025-10-31T13:32:56.760-07:00", | ||
| "description": "Description for gg-asset-42745-fa77", | ||
| "diskSizeGb": "20", |
Owner
There was a problem hiding this comment.
Suggested change
| "diskSizeGb": "20", | |
| "diskSizeGb": 20, |
| "creationTimestamp": "2025-10-31T13:32:56.760-07:00", | ||
| "description": "Description for gg-asset-42745-fa77", | ||
| "diskSizeGb": "20", | ||
| "enableConfidentialCompute": false, |
Owner
There was a problem hiding this comment.
Suggested change
| "enableConfidentialCompute": false, |
Comment on lines
+16
to
+27
| { | ||
| "type": "UEFI_COMPATIBLE" | ||
| }, | ||
| { | ||
| "type": "MULTI_IP_SUBNET" | ||
| }, | ||
| { | ||
| "type": "VIRTIO_SCSI_MULTIQUEUE" | ||
| }, | ||
| { | ||
| "type": "GVNIC" | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| { | |
| "type": "UEFI_COMPATIBLE" | |
| }, | |
| { | |
| "type": "MULTI_IP_SUBNET" | |
| }, | |
| { | |
| "type": "VIRTIO_SCSI_MULTIQUEUE" | |
| }, | |
| { | |
| "type": "GVNIC" | |
| } | |
| { | |
| "type": "UEFI_COMPATIBLE" | |
| }, | |
| { | |
| "type": "MULTI_IP_SUBNET" | |
| } |
Comment on lines
+40
to
+41
| "https://www.googleapis.com/compute/v1/projects/debian-cloud/global/licenses/debian-11-bullseye", | ||
| "https://www.googleapis.com/compute/v1/projects/vm-options/global/licenses/enable-vmx" |
Owner
There was a problem hiding this comment.
Suggested change
| "https://www.googleapis.com/compute/v1/projects/debian-cloud/global/licenses/debian-11-bullseye", | |
| "https://www.googleapis.com/compute/v1/projects/vm-options/global/licenses/enable-vmx" | |
| "projects/vm-options/global/licenses/enable-vmx" |
| "https://www.googleapis.com/compute/v1/projects/vm-options/global/licenses/enable-vmx" | ||
| ], | ||
| "name": "gg-asset-42745-fa77", | ||
| "selfLink": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/global/images/gg-asset-42745-fa77", |
Owner
There was a problem hiding this comment.
Suggested change
| "selfLink": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/global/images/gg-asset-42745-fa77", |
| ], | ||
| "name": "gg-asset-42745-fa77", | ||
| "selfLink": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/global/images/gg-asset-42745-fa77", | ||
| "sourceDisk": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a/disks/gg-asset-source-disk-42745-fa77", |
Owner
There was a problem hiding this comment.
Suggested change
| "sourceDisk": "https://www.googleapis.com/compute/v1/projects/{{.Provider.project}}/zones/us-central1-a/disks/gg-asset-source-disk-42745-fa77", | |
| "sourceDisk": "projects/{{.Provider.project}}/zones/us-central1-a/disks/gg-asset-source-disk-42745-fa77", |
Comment on lines
+46
to
+48
| "sourceDiskId": "1795891860089643546", | ||
| "sourceType": "RAW", | ||
| "status": "READY", |
Owner
There was a problem hiding this comment.
Suggested change
| "sourceDiskId": "1795891860089643546", | |
| "sourceType": "RAW", | |
| "status": "READY", |
| }, | ||
| "discovery_document_uri": "https://www.googleapis.com/discovery/v1/apis/compute/v1/rest", | ||
| "discovery_name": "Image", | ||
| "location": "us-central1", |
Owner
There was a problem hiding this comment.
Suggested change
| "location": "us-central1", |
Adds a Terraform Plan to CAI converter for the `google_compute_image` resource. This includes registering the pre-existing converter and adding a new test case to validate its functionality. This also addresses feedback from the pull request to use snake_case for JSON keys in the test file, remove the `google_compute_disk` resource from the test case, and update the hardcoded `source_disk` value.
hemantadil
reviewed
Nov 1, 2025
| "goog-terraform-provisioned": "true" | ||
| }, | ||
| "licenses": [ | ||
| "https://www.googleapis.com/compute/v1/projects/vm-options/global/licenses/enable-vmx" |
Owner
There was a problem hiding this comment.
Suggested change
| "https://www.googleapis.com/compute/v1/projects/vm-options/global/licenses/enable-vmx" | |
| "projects/vm-options/global/licenses/enable-vmx" |
Adds a Terraform Plan to CAI converter for the `google_compute_image` resource. This includes registering the pre-existing converter and adding a new test case to validate its functionality. This also addresses feedback from the pull request to use snake_case for JSON keys in the test file, remove the `google_compute_disk` resource from the test case, and update the hardcoded `source_disk` value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a Terraform Plan to CAI converter for the
google_compute_imageresource. It registers the converter inmmv1/third_party/tgc/resource_converters.go.tmpland adds a new test case with both.tfand.jsonfiles.PR created automatically by Jules for task 16704852344800286332