feat: add converter for compute.googleapis.com/Image#8
feat: add converter for compute.googleapis.com/Image#8google-labs-jules[bot] wants to merge 3 commits into
Conversation
This change adds a new converter for the `compute.googleapis.com/Image` asset type. The following changes are included: - A new entry for `google_compute_image` has been added to `mmv1/third_party/tgc/resource_converters.go.tmpl`. - A comprehensive test case has been added to `mmv1/third_party/tgc/tests/data/` to validate the converter.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
| "ancestors": [ | ||
| "projects/{{.Project.Number}}", | ||
| "organizations/{{.OrgID}}" | ||
| ], |
There was a problem hiding this comment.
use ancestry_path in place of this
| terraform { | ||
| required_providers { | ||
| google = { | ||
| source = "hashicorp/google" | ||
| version = ">= 4.54.0" | ||
| } | ||
| } | ||
| } |
| variable "project_id" { | ||
| description = "The project ID to host the resources." | ||
| type = string | ||
| } | ||
|
|
||
| variable "organization_id" { | ||
| description = "The organization ID." | ||
| type = string | ||
| } |
| } | ||
|
|
||
| provider "google" { | ||
| project = var.project_id |
| data "google_project" "project" { | ||
| } |
This change adds a new converter for the `compute.googleapis.com/Image` asset type. The following changes are included: - A new entry for `google_compute_image` has been added to `mmv1/third_party/tgc/resource_converters.go.tmpl`. - A comprehensive test case has been added to `mmv1/third_party/tgc/tests/data/` to validate the converter. - Addressed comments on the pull request.
1 participant
This change adds a new converter for the
compute.googleapis.com/Imageasset type. The converter handles the mapping between the Terraform plan and the CAI asset, including fields such asname,source_snapshot,disk_size_gb, andlicenses. A new test case has been added to validate the converter.PR created automatically by Jules for task 7007410325176438087