Add LogSink converter#6
Conversation
Adds a new converter for the `google_logging_folder_sink` Terraform resource, converting it to the `logging.googleapis.com/LogSink` CAI asset type. This change includes: - The converter implementation in `mmv1/third_party/tgc/services/logging/logging_folder_sink.go`. - Registration of the new converter in the necessary files. - A test case with corresponding `.tf` and `.json` files to validate the converter's functionality.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
| Type: LogSinkAssetType, | ||
| Resource: &cai.AssetResource{ | ||
| Version: "v2", | ||
| DiscoveryDocumentURI: "https://logging.googleapis.com/$discovery/rest?version=v2", |
Adds a new converter for the `google_logging_folder_sink` Terraform resource, converting it to the `logging.googleapis.com/LogSink` CAI asset type. This change includes: - The converter implementation in `mmv1/third_party/tgc/services/logging/logging_folder_sink.go`. - Registration of the new converter in the necessary files. - A test case with corresponding `.tf` and `.json` files to validate the converter's functionality.
| } | ||
| } | ||
| if folder.(string) == "" { | ||
| if val, ok := d.GetOk("after_unknown.folder"); ok { |
There was a problem hiding this comment.
This doesn't look like right. Would we get after_unknown field
Adds a new converter for the `google_logging_folder_sink` Terraform resource, converting it to the `logging.googleapis.com/LogSink` CAI asset type. This change includes: - The converter implementation in `mmv1/third_party/tgc/services/logging/logging_folder_sink.go`. - Registration of the new converter in the necessary files. - A test case with corresponding `.tf` and `.json` files to validate the converter's functionality.
| folderId := strings.TrimPrefix(folder.(string), "folders/") | ||
| obj["parent"] = fmt.Sprintf("//cloudresourcemanager.googleapis.com/folders/%s", folderId) |
There was a problem hiding this comment.
There is no parent field inside data field
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Remove the parent field from data field
Removed unused imports from logging_folder_sink.go
1 participant
This submission adds a new converter for the
google_logging_folder_sinkTerraform resource, converting it to thelogging.googleapis.com/LogSinkCAI asset type. It includes the converter implementation, registration, and a test case.PR created automatically by Jules for task 8494212493473801670