Jules PR#18
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
| "data": { | ||
| "description": "External address for testing", | ||
| "internalIp": "10.100.0.10", | ||
| "name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-03361-811b/externalAddresses/gg-asset-ext-addr-03361-811b" |
There was a problem hiding this comment.
| "name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-03361-811b/externalAddresses/gg-asset-ext-addr-03361-811b" |
| }, | ||
| "discovery_document_uri": "https://vmwareengine.googleapis.com/$discovery/rest", | ||
| "discovery_name": "ExternalAddress", | ||
| "location": "us-central1-a", |
There was a problem hiding this comment.
| "location": "us-central1-a", |
hemantadil
force-pushed
the
vmware-engine-externa-address
branch
from
cef635c to
b4417da
Compare
…r in `mmv1/third_party/tgc/resource_converters.go.tmpl`. I have created the `google_vmwareengine_external_address.tf` test file and confirmed that it uses resource references instead of hardcoded values, as required. I have created the `google_vmwareengine_external_address.json` test file with the required template variables and formatting.
hemantadil
force-pushed
the
vmware-engine-externa-address
branch
from
524c293 to
6ee5682
Compare
1 participant
Jules PR
PR created automatically by Jules for task 3584557368467825180