Skip to content

feat: Add vmwareengine cluster converter#16

Draft
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
feat-vmware-cluster-converter
Draft

feat: Add vmwareengine cluster converter#16
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
feat-vmware-cluster-converter

Conversation

@google-labs-jules

Copy link
Copy Markdown

This change introduces a new converter for the google_vmwareengine_cluster resource, enabling the conversion of Terraform plans to CAI format. A test case is also included to validate the converter's functionality.


PR created automatically by Jules for task 3506915735971980056

@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

Comment thread mmv1/third_party/tgc/tests/data/google_vmwareengine_cluster.json
"version": "v1",
"discovery_document_uri": "https://vmwareengine.googleapis.com/$discovery/rest",
"discovery_name": "Cluster",
"parent": "//cloudresourcemanager.googleapis.com/projects/{{.Project.Number}}",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"parent": "//cloudresourcemanager.googleapis.com/projects/{{.Project.Number}}",
"parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

"discovery_name": "Cluster",
"parent": "//cloudresourcemanager.googleapis.com/projects/{{.Project.Number}}",
"data": {
"name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-38930-c6db/clusters/gg-asset-cl-38930-c6db",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-38930-c6db/clusters/gg-asset-cl-38930-c6db",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

"discovery_name": "Cluster",
"parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}",
"data": {
"name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-38930-c6db/clusters/gg-asset-cl-38930-c6db",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-38930-c6db/clusters/gg-asset-cl-38930-c6db",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hemantadil hemantadil force-pushed the feat-vmware-cluster-converter branch 5 times, most recently from 88d1163 to 172c3f4 Compare November 5, 2025 19:27
Adds a converter for the `google_vmwareengine_cluster` resource,
and a corresponding test case.
@hemantadil hemantadil force-pushed the feat-vmware-cluster-converter branch from 172c3f4 to e455331 Compare November 6, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant