Jules PR#11
Conversation
… {kms.ResourceConverterKMSCryptoKey()} mapping to mmv1/third_party/tgc/resource_converters.go.tmpl.
I have created the test case files `mmv1/third_party/tgc/tests/data/kms_crypto_key.tf` and `mmv1/third_party/tgc/tests/data/kms_crypto_key.json` and populated them with the provided example data, replacing hardcoded values with the correct template variables.
I have removed the incorrect mapping for `google_compute_image` from `mmv1/third_party/tgc/resource_converters.go.tmpl`.
The test case files `mmv1/third_party/tgc/tests/data/kms_crypto_key.tf` and `mmv1/third_party/tgc/tests/data/kms_crypto_key.json` have already been created.
I have deleted the `terraform-google-conversion` directory to ensure a clean slate.
I have re-cloned the `terraform-google-conversion` repository into the correct directory.
I have regenerated the converter code by running `make tgc` and setting the `OUTPUT_PATH`.
I have applied the workarounds for the known build errors in `iam_workbench_instance.go` and `accesscontextmanager_service_perimeter.go`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
| "projects/{{.Project.Number}}", | ||
| "organizations/{{.OrgID}}" | ||
| ], | ||
| "assetType": "cloudkms.googleapis.com/CryptoKey", |
There was a problem hiding this comment.
| "assetType": "cloudkms.googleapis.com/CryptoKey", | |
| "asset_type": "cloudkms.googleapis.com/CryptoKey", |
1 participant
Jules PR
PR created automatically by Jules for task 9804368232088253400