Skip to content

Add metadata for RubyGems#5378

Merged
carlosantoniodasilva merged 1 commit into
heartcombo:masterfrom
nickhammond:patch-1
May 8, 2021
Merged

Add metadata for RubyGems#5378
carlosantoniodasilva merged 1 commit into
heartcombo:masterfrom
nickhammond:patch-1

Conversation

@nickhammond
Copy link
Copy Markdown
Contributor

Add the various links to RubyGems so people can go directly to various places such as the changelog when upgrading.

Copy link
Copy Markdown
Member

@carlosantoniodasilva carlosantoniodasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks, I've had that noted down somewhere to review at some point. I had a couple of comments, mainly the source code vs bug tracker URI (and we may need both?), let me know what you think.

Comment thread devise.gemspec Outdated
Comment thread devise.gemspec Outdated
"changelog_uri" => "https://github.com/heartcombo/devise/blob/master/CHANGELOG.md",
"source_code_uri" => "https://github.com/heartcombo/devise/issues",
"wiki_uri" => "https://github.com/heartcombo/devise/wiki",
"mailing_list_uri" => "http://stackoverflow.com/questions/tagged/devise"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have a mailing list under heartcombo: https://groups.google.com/g/heartcombo... I'm not sure I want to point people to there though as I have been thinking about killing it, but maybe it's a better option to start. I'm also not sure about pointing to stackoverflow here, but I guess that's where we point people from the readme anyway... just seems a little odd to have it here for some reason 😅

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yah I was just grabbing it from the readme but definitely up to the core contributors. I think the Google Groups mailing list must be private as it redirects me to https://groups.google.com/access-error?continue=https://groups.google.com/g/heartcombo. We could of course just remove it for now, I was just trying to enhance the metadata with what's available.

@carlosantoniodasilva
Copy link
Copy Markdown
Member

Btw, we might be able to add documentation_uri as well, pointing to: https://rubydoc.info/github/heartcombo/devise for now.

@nickhammond
Copy link
Copy Markdown
Contributor Author

@carlosantoniodasilva I think we want both source_code_uri and bug_tracker_uri, I tried to batch commit both of your suggestions but had to manually do the other one. I've also added the documentation_uri to point to https://rubydoc.info/github/heartcombo/devise.

Thanks for making such a great gem for the community over all these years!

@carlosantoniodasilva
Copy link
Copy Markdown
Member

Oh right, I think google groups now require you to be logged in to google or something... anyway let's not worry about it, like I said I'm probably gonna kill it at some point, maybe come up with something else instead.

And no worries about the batch commit, if you can't squash everything I can do it when merging. I'll take another look later/tomorrow. Thanks again!

@nickhammond
Copy link
Copy Markdown
Contributor Author

mailing_list_uri removed and commits squashed!

@carlosantoniodasilva carlosantoniodasilva merged commit c82e4cf into heartcombo:master May 8, 2021
@carlosantoniodasilva
Copy link
Copy Markdown
Member

Perfect, thank you!

@nickhammond nickhammond deleted the patch-1 branch June 18, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants