Alerts for job posts based on filtersets [WIP] by shreyas-satish · Pull Request #435 · hasgeek/hasjob

shreyas-satish · 2018-04-12T10:37:23Z

Adds the ability to subscribe to alerts for job posts via email. The alerts can be configured for job posts that match one or multiple combinations for filters. Support for push notifications will be added in the next release.
Adds a custom __init__ for Filterset to help create filtersets using a dict of filters.

Job alert email

* initial changes for state manager for job application * added transitions for application processing * more fixes * transition fixes

…cleanup

jace · 2018-04-13T09:00:20Z

hasjob/jobs/job_alerts.py

+from premailer import transform as email_transform
+from hasjob import mail
+from hasjob.models import db, JobPost, JobPostSubscription, JobPostAlert, jobpost_alert_table
+from hasjob.views.index import fetch_jobposts


I'm uncomfortable with jobs.* importing from views.*. Jobs are supposed to be independent of views. Can we isolate this (and other associated) functions into a separate helper module? We have many RQ jobs in views/helper.py that need to move as well.

jace · 2018-04-13T09:01:35Z

hasjob/jobs/job_alerts.py

+    posts = fetch_jobposts(filters=subscription.filterset.to_filters(), posts_only=True)
+    seen_jobpostids = JobPost.query.join(jobpost_alert_table).join(JobPostAlert).filter(
+        JobPostAlert.jobpost_subscription == subscription).options(db.load_only('id')).all()
+    return [post for post in posts if post.id not in seen_jobpostids]


All of this could be a single server-side query.

jace · 2018-04-13T09:04:01Z

hasjob/jobs/job_alerts.py

+
+@job('hasjob')
+def send_email_alerts():
+    for subscription in JobPostSubscription.get_active_subscriptions():


Active+right time must be a single query. You will be skipping more than sending, so this is going to pull in a lot of irrelevant subscriptions.

jace · 2018-04-13T09:05:50Z

hasjob/jobs/job_alerts.py

+            mail.send(msg)
+            jobpost_alert.register_delivery()
+        except Exception as exc:
+            jobpost_alert.register_failure(unicode(exc))


Since exceptions should not happen, don't do a catch-all. Let this trigger our exception reporting.

jace · 2018-04-13T09:09:21Z

hasjob/models/filterset.py

    #: Welcome text
    description = db.Column(db.UnicodeText, nullable=False, default=u'')
+    #: Display on sitemap
+    sitemap = db.Column(db.Boolean, default=False, nullable=True, index=True)


You'll need to allow nullable names and titles as well, and maybe just use that as the sitemap filter.

It just occurred to me that Filterset should use UUID keys, and should use url_name_suuid in URLs, since we'll keep tweaking name and title for SEO.

jace · 2018-04-13T09:56:31Z

hasjob/views/index.py



-def fetch_jobposts(request_args, request_values, filters, is_index, board, board_jobs, gkiosk, basequery, md5sum, domain, location, title, showall, statusfilter, batched, ageless, template_vars, search_query=None, query_string=None):
+def fetch_jobposts(request_args={}, request_values={}, filters={}, is_index=False, board=None, board_jobs={}, gkiosk=False, basequery=None, md5sum=None, domain=None, location=None, title=None, showall=True, statusfilter=None, batched=True, ageless=False, template_vars={}, search_query=None, query_string=None, posts_only=False):


I think it's time to fix this mess. :-)

jace · 2018-04-13T10:02:53Z

hasjob/views/job_alerts.py

+
+
+@app.route('/subscribe_to_job_alerts', subdomain='<subdomain>', methods=['POST'])
+@app.route('/subscribe_to_job_alerts', methods=['POST'])


I don't think we should pollute the top-level namespace with these URLs. Park them in a path. /api/1/ should work. See #145 for rationale.

jace · 2018-04-13T10:07:28Z

hasjob/views/job_alerts.py

+@app.route('/subscribe_to_job_alerts', methods=['POST'])
+def subscribe_to_job_alerts():
+    if not request.json or not request.json.get('filters'):
+        abort(400)


This should be a requestargs decorator. It doesn't process from request.json, but that's trivial to add in Coaster.

jace · 2018-04-13T10:44:45Z

manage.py



+@periodic.command
+def send_job_alerts():


Make this send_jobpost_alerts since job and jobpost are distinct concepts.

jace · 2018-04-13T10:45:33Z

manage.py

+@periodic.command
+def send_job_alerts():
+    """Run email alerts every 10 minutes"""
+    send_email_alerts.delay()


Consider using RQ Scheduler for this: https://github.com/rq/rq-scheduler

…ost_subscription

CLAassistant · 2022-05-16T15:15:34Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Vidya Ramakrishnan
❌ shreyas-satish

Vidya Ramakrishnan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

shreyas-satish and others added 8 commits April 5, 2018 21:22

subscriptions [wip]

23519c0

working backend for job alerts

620d045

simplify and cleanup

3c457f0

Using StateManager for JobApplication model (#432)

df699d7

* initial changes for state manager for job application * added transitions for application processing * more fixes * transition fixes

turn off autocomplete for the filters form

7e87088

changed background job to 10 minutes, custom __init__ for Filterset, …

3681656

…cleanup

added user association. added timing for alerts. cleanup

75c8976

Merge branch 'job-alerts' into jobalerts

3583eb3

shreyas-satish mentioned this pull request Apr 12, 2018

Email alerts for new job posts [WIP] #434

Closed

added time check for alert sending. cleanup. set sitemap

661d6c7

jace requested changes Apr 13, 2018

View reviewed changes

shreyas-satish force-pushed the jobalerts branch from 93350a5 to 661d6c7 Compare April 16, 2018 17:07

shreyas-satish and others added 14 commits April 16, 2018 22:40

Merge branch 'master' into jobalerts

9903e76

removed fail logging. versioned api endpoints. added cascade for jobp…

c085782

…ost_subscription

make title and name in filterset nullable

dfe052e

changed function name

ed3a605

Merge branch 'master' into jobalerts

0f9e3ac

user or anon_user

9d0432d

added frequency to subscription init

20512a2

Add form to subscribe to email alerts for job posts.

da775ca

Sync with latest.

30993bd

use form for email_frequency

27c2104

Update UI of job alerts form.

0623088

Update text of subscribe form. Remove the border.

1219f55

Update alert mailer template.

7a818d0

Merge branch 'master' into jobalerts

f82ee05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alerts for job posts based on filtersets [WIP]#435

Alerts for job posts based on filtersets [WIP]#435
shreyas-satish wants to merge 23 commits intomainfrom
jobalerts

shreyas-satish commented Apr 12, 2018 •

edited by vidya-ram

Loading

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

jace Apr 13, 2018

Uh oh!

CLAassistant commented May 16, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants



		def fetch_jobposts(request_args, request_values, filters, is_index, board, board_jobs, gkiosk, basequery, md5sum, domain, location, title, showall, statusfilter, batched, ageless, template_vars, search_query=None, query_string=None):
		def fetch_jobposts(request_args={}, request_values={}, filters={}, is_index=False, board=None, board_jobs={}, gkiosk=False, basequery=None, md5sum=None, domain=None, location=None, title=None, showall=True, statusfilter=None, batched=True, ageless=False, template_vars={}, search_query=None, query_string=None, posts_only=False):



		@app.route('/subscribe_to_job_alerts', subdomain='<subdomain>', methods=['POST'])
		@app.route('/subscribe_to_job_alerts', methods=['POST'])

Conversation

shreyas-satish commented Apr 12, 2018 • edited by vidya-ram Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented May 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shreyas-satish commented Apr 12, 2018 •

edited by vidya-ram

Loading

CLAassistant commented May 16, 2022 •

edited

Loading