Skip to content

Correct behaviour of default auth strategy#460

Merged
Nargonath merged 1 commit into
hapijs:masterfrom
lauraseidler:fix/default-auth-strategy
Apr 16, 2021
Merged

Correct behaviour of default auth strategy#460
Nargonath merged 1 commit into
hapijs:masterfrom
lauraseidler:fix/default-auth-strategy

Conversation

@lauraseidler

Copy link
Copy Markdown
Contributor

Fixes #459

@devinivy devinivy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Nargonath Nargonath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Should we open a follow-up issue to ask for help from the community for an update in the other languages?

@devinivy

Copy link
Copy Markdown
Member

@Nargonath that sounds like a good call 👍 . We could additionally remove the incorrect information from those translations in the interim— I think saying nothing at all about this might be an improvement over the incorrect information.

@Nargonath

Copy link
Copy Markdown
Contributor

Alright. I'll merge this MR then and create 2 new issue: one for the removal and one for "help wanted" on translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Non-code related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation on default auth strategy incorrect?

3 participants