Skip to content

ci: skip CUDA and Metal jobs on pull requests - #12

Merged
dzannotti merged 3 commits into
masterfrom
ci/disable-cuda-metal-pr-checks
Aug 30, 2026
Merged

dzannotti merged 3 commits into
masterfrom
ci/disable-cuda-metal-pr-checks

Conversation

@gaetan-puleo

Copy link
Copy Markdown
Collaborator

Overview

This PR disables CUDA and Metal build jobs for pull request events while preserving them for pushes to master and manual workflow dispatches.

The goal is to avoid unrelated CUDA and Apple Metal failures blocking Strix Halo ROCm/Vulkan pull requests.

The following PR jobs are skipped:

  • CUDA Ubuntu
  • macOS ARM64 Metal
  • iOS Metal
  • tvOS Metal
  • visionOS Metal
  • Swift Metal builds

The following checks remain enabled on pull requests:

  • HIP
  • MUSA
  • macOS x64 with Metal disabled
  • Other existing CPU, Vulkan, formatting, and quality workflows

The workflows are not deleted. CUDA and Metal coverage continues to run on master and through workflow_dispatch.

Measurements

Not applicable. This PR changes GitHub Actions event conditions only and cannot affect runtime performance, model output, or memory use.

Additional information

Each affected job uses:

if: github.event_name != 'pull_request'

This keeps the workflow definitions available without scheduling those jobs for PR events.

What was not verified:

  • Repository branch-protection rules that may still list these jobs as required checks
  • Manual workflow execution after merge
  • CUDA or Metal compilation, because this PR intentionally changes only when those jobs run

Requirements

  • I have read and agree with the contributing guidelines
  • This change is specific to the Strix Halo fork's CI policy
  • AI usage disclosure: AGENT-AUTHORED - OpenCode assisted with implementation, branch preparation, and this PR description
  • What was NOT verified: branch-protection configuration and post-merge manual dispatch

@dzannotti
dzannotti merged commit e2e49a0 into master Aug 30, 2026
5 of 9 checks passed
@dzannotti
dzannotti deleted the ci/disable-cuda-metal-pr-checks branch August 30, 2026 22:02
asf0 pushed a commit to asf0/strix-llama.cpp that referenced this pull request Oct 12, 2026
Brings in 221 upstream commits, including ggml-org#14891 (activation-based imatrix
statistics for GGUF imatrices).

Resolutions:
- qwen4exp: take upstream's MTP (ggml-org#29761) over this fork's halo-box#9 head. The two
  write different GGUFs (upstream keeps the MTP block's own hyper-connection
  mixer as nextn.hc_head_* and runs the draft with QSA), and current MTP
  files use upstream's layout. Also drop halo-box#9's attention-only MTP memory for
  qwen4exp in llama-model.cpp and its extra NEXTN entries in constants.py.
- speculative: keep --spec-draft-adaptive's n_draft_eff bound on top of
  upstream's probabilistic draft sampling (result_q); begin() resets both
  the acceptance EMA and the sampler.
- ggml-backend: take upstream's pass-6 input collection (ggml-org#29634) and
  ggml_backend_sched_copy_input() (ggml-org#29943), keeping halo-box#23's copy-0 original
  with input rotation, async-read pinning, and the sanitizer hook.
- vulkan: keep halo-box#12's UMA read-back gate (host-cached or <= 64 KiB direct);
  upstream's AMD-only fix is a subset of it.
- server: keep spec-prefill's prompt_src() next to upstream's
  use_spec_rejection(); use add_embd() with M-RoPE positions.
- speculative-prefill: migrate to common_batch / llama_process, as upstream
  ggml-org#29601 removed common_batch_add/clear.
- README: keep this fork's quick start; common.h, test-alloc: keep both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants