Repository navigation
fix(numbers): distinguish expected empty search outcomes - #419
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telnyx returns HTTP 400 for some valid number searches with no coverage or no stock. Hail already handles these as empty inventory, but activity reviews could only see the error-looking HTTP span.
Add one INFO log for recognized empty responses with
number_search_outcome: no_coverageorno_inventory, country, type, capabilities and fixed carrier error codes. The log excludes phone numbers, place filters, credentials and raw responses. Normal HTTP 200 searches add no log. Search criteria, pricing, offers and failure handling stay unchanged.Investigation on 2026-11-15: one read-only request per distinct KN toll-free SMS, KN toll-free voice/SMS and TT toll-free voice/SMS filter reproduced the explicit
10015no-coverage response. This does not establish permanent country or type coverage. Historical response bodies were not recorded.Validation:
Review: 1 of 1 commits. No actionable findings.
Reviewed through: 9cb8d49 (1 of 1 commits)