Skip to content

fix(numbers): distinguish expected empty search outcomes - #419

Merged
r13i merged 3 commits into
mainfrom
fix/number-search-errors
Nov 17, 2026
Merged

r13i merged 3 commits into
mainfrom
fix/number-search-errors

Conversation

@r13i

@r13i r13i commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Telnyx returns HTTP 400 for some valid number searches with no coverage or no stock. Hail already handles these as empty inventory, but activity reviews could only see the error-looking HTTP span.

Add one INFO log for recognized empty responses with number_search_outcome: no_coverage or no_inventory, country, type, capabilities and fixed carrier error codes. The log excludes phone numbers, place filters, credentials and raw responses. Normal HTTP 200 searches add no log. Search criteria, pricing, offers and failure handling stay unchanged.

Investigation on 2026-11-15: one read-only request per distinct KN toll-free SMS, KN toll-free voice/SMS and TT toll-free voice/SMS filter reproduced the explicit 10015 no-coverage response. This does not establish permanent country or type coverage. Historical response bodies were not recorded.

Validation:

  • All GitHub checks passed, including every Python suite, lint, Go, Docker and OpenAPI.
  • Full core suite: 2,324 passed, 11 skipped.
  • New outcome/privacy cases failed before implementation and passed afterward.
  • Black and Ruff passed for changed Python files; Markdown formatting and diff checks passed.
  • The production logging handler and privacy filter retain all six safe outcome fields.

Review: 1 of 1 commits. No actionable findings.

Reviewed through: 9cb8d49 (1 of 1 commits)

@vercel

vercel Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hail-costs Ready Ready Preview Nov 16, 2026 8:53pm UTC
hail-docs Ready Ready Preview Nov 16, 2026 8:53pm UTC

Request Review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@r13i
r13i merged commit c265d8e into main Nov 17, 2026
13 checks passed
@r13i
r13i deleted the fix/number-search-errors branch November 17, 2026 08:13

This branch was successfully deployed

2 active deployments
Preview – hail-docs — 0857a92b Deployed Nov 16, 2026 by vercel[bot]
Preview – hail-costs — 0857a92b Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant