Fix for issue #42#46
Conversation
Removed dependency on deprecated method (temperature utility), as it will break in april 2023. For now, reverted to not converting any temperatures, as the rest of the code only seems to work with Celsius. Future development; reintroduce temperature conversion, based on TemperatureConverter (home assistant unit_conversion.py in util folder).
|
Thanks for this code change @kkoenen I have also:
Your contributions are very much appreciated (especially in the chill of winter 🥶 😄 ) |
|
I posted an update in #38 -see #38 (comment) It appears that the code at HEAD in the branch I think the current code removes the conversion (via the deprecated temperature utility), and doesn't reintroduce a new conversion yet? So I think what this is saying is the integration doesn't need to convert the temperatures, because Home Assistant is doing that. So currently, these temperature (attributes) of the climate device seem to be localized correctly to F for me in the US: However, these temperatures are NOT getting localized correctly and still appear to be in 'C'. So perhaps these need to have their class/unit set correctly like the others that are being localized correctly? Thanks for the work on this! |
Removed dependency on deprecated method (temperature utility), as it will break in april 2023. For now, reverted to not converting any temperatures, as the rest of the code only seems to work with Celsius.
Future development; reintroduce temperature conversion, based on TemperatureConverter (home assistant unit_conversion.py in util folder).