Skip to content

avoid unused-variable warning - #834

Merged
h2zero merged 2 commits into
h2zero:masterfrom
mazgch:patch-1
Jan 4, 2025
Merged

h2zero merged 2 commits into
h2zero:masterfrom
mazgch:patch-1

Conversation

@mazgch

@mazgch mazgch commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Avoid warning when compiled with All warnings enabled.

.../src/NimBLEScan.cpp: In member function 'void NimBLEScanResults::dump() const': 
.../src/NimBLEScan.cpp:481:22: warning: unused variable 'dev' [-Wunused-variable]
  481 |     for (const auto& dev : m_deviceVec) {
      |                      ^~~

alternatively the #if could even wrap the whole for loop ...

Avoid warning when compiled with All warnings enabled. 
.../src/NimBLEScan.cpp: In member function 'void NimBLEScanResults::dump() const':
.../src/NimBLEScan.cpp:481:22: warning: unused variable 'dev' [-Wunused-variable]
  481 |     for (const auto& dev : m_deviceVec) {
      |                      ^~~
@h2zero

h2zero commented Jan 3, 2025

Copy link
Copy Markdown
Owner

Thanks! I thought I had fixed this already but I guess it didn't get merged. Could you change this to just wrap the loop with #if CONFIG_NIMBLE_CPP_LOG_LEVEL >=3 please?

@mazgch

mazgch commented Jan 4, 2025

Copy link
Copy Markdown
Contributor Author

I changed as per your request.

@h2zero

h2zero commented Jan 4, 2025

Copy link
Copy Markdown
Owner

Thanks!

@h2zero
h2zero merged commit f4746f2 into h2zero:master Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants