For Python 3.13: A drop-in replacement for imghdr.what()#178
Closed
cclauss wants to merge 2 commits intoh2non:masterfrom
Closed
For Python 3.13: A drop-in replacement for imghdr.what()#178cclauss wants to merge 2 commits intoh2non:masterfrom
imghdr.what()#178cclauss wants to merge 2 commits intoh2non:masterfrom
Conversation
imghdr.what()
Contributor
Author
|
Closing in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python 3.13 release notes mention
filetype.pyas one of the alternatives forimghdrwhich was removed from the Standard Library.Given the discussion in #175, it might be quite helpful to have a drop-in replacement for
imghdr.what(). It would provide a smooth transition to Py3.13 if developers could confidently replace all instances ofimghdr.what()withfiletype.what()-- same args, same results.Current pytest results:
49 passed in 0.04stest_what_from_fileis 4 testsztest_what_from_file_noneis 0 test -- disabled with the leadingztest_what_from_stringis 10 teststest_what_from_string_py311is 2 testsimghdronly on Python < 3.11test_what_from_string_todois 33 tests -- Lots of work to do!filetypeUsage:
imghdrdocumentation: https://docs.python.org/3.12/library/imghdr.htmlimghdrsource code: https://github.com/python/cpython/blob/3.12/Lib/imghdr.py