Repository navigation
Add tooth tip fillets to gears - #88
Open
GabrielJMS wants to merge 1 commit into
Open
GabrielJMS wants to merge 1 commit into
GabrielJMS wants to merge 1 commit into
Conversation
Add an optional tip_fillet that rounds the two convex tip corners of each tooth, threaded through InvoluteToothProfile, SpurGearPlan, SpurGear, HelicalGear, WormWheel, WormGear, RackGearPlan and RackGear alongside root_fillet. None or 0 leaves the profile unchanged. The radius is checked before filleting: a negative value raises, and so does one whose fillets would overlap on the tip land. For involute teeth the fillet centre lies on the flank involute offset inward by the radius, so the limit is exact rather than a straight-line estimate. For an internal gear made by subtracting a SpurGearPlan from a circle, tip_fillet rounds the internal gear's root and root_fillet its tooth tip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gear drawings usually specify a tip round (e.g. R0.2) as well as a root fillet. This PR adds an optional
tip_filletargument that rounds the two convex tip corners of each tooth:tip_fillet (float, optional): radius of the tooth-tip fillet. None or 0 leaves sharp tips. Defaults to None.It is available on
InvoluteToothProfile,SpurGearPlan,SpurGear,HelicalGear,WormWheel,WormGear,RackGearPlanandRackGear. It sits with the other profile parameters, afterdedendum(afterbase_heighton the rack) and beforerotation/align/mode, so calls that pass the profile parameters positionally are unaffected; a call passingrotationpositionally would need to name it.Negative radii raise, as does a radius whose fillets would overlap on the tip land; for involute teeth this limit is computed exactly from the offset involute. On helical gears the radius is measured in the transverse plane, like
root_fillet. For an internal gear made by subtracting aSpurGearPlan,tip_filletrounds the ring's root androot_filletits tooth tip (documented).Tests cover validity, area/volume, the fillet arcs, invalid radii and the no-op cases.
🤖 Generated with Claude Code