Update for eslint@>2.x#13
Update for eslint@>2.x#13BurtHarris wants to merge 2 commits intogulpjs:masterfrom BurtHarris:workitem_10
Conversation
|
I don't think we needs peerDeps |
|
You are probably right, I was thinking that would cause dependent projects to generate a warning if they are still using eslint@1, but testing it out that doesn't seem to work, at least with npm@3.10.10. Update: No, I take that back. I get the following message if the update isn't done in a dependency: That's what I was expecting. |
per @phated's feedback Doesn't seem to hurt if using eslint@1 or eslint@2
|
@phated I've removed the peer dependency. Doesn't seem to hurt anything without it. |
|
Yeah, peerDependencies were deprecated in npm@3 (per http://blog.npmjs.org/post/110924823920/npm-weekly-5) |
|
@pdehaan, I think peerDependencies had their behavior changed in npm@3, but not deprecated. The behavior I expected is exactly what it says in that blog entry:
peerDependencies are in use in several well-maintained projects I've worked with, for example gulp-tsb has a peerDependency on the TypeScript transpiler. This way a warning is generated if TypeScript isn't also part of the same project that gulp-tsb is. But gulp-tsb doesn't get it's own copy, it uses the version the containing project uses. |
|
Bump. Blocking gulpjs/vinyl-fs#270 |
|
Still considering this for eslint@2 support. I'm going to take a look at this stuff with #8 |
The `gulp self` tasks couldn't be run without a Gulpfile present, and a local dependency on Gulp itself. Instead, we move to use npm scripts, and the individual tools themselves (unwrapped from gulp). There are three self-linting tasks: - `jsonlint` - which validates some JSON files. More files can be added as needed. - `esvalidate` - which ensures JavaScript files are valid. The output doesn't appear to show the file name, and the suggestion at duereg/esvalidate#3 doesn't appear to work for me. - `eslint` - checks for good JavaScript coding practices and formatting. Rather than sticking with `eslint-config-wordpress` (which checks JS which will run in the browser), this uses the `eslint-config-gulp` config. These can be run with, for instance, `npm run eslint`. All of the self-linting tasks can be in one go with `npm run lint`. `npm test` exists as a convenience too. The eslintConfig in `package.json` avoids the need to have a separate `.eslintrc` file. We extend the `eslint-config-gulp` config, and specify we're using ES6. The rules section is needed to avoid false positives regarding a change of rule name. These rules can be fixed as and when gulpjs/eslint-config-gulp#13 gets merged. See #25.
|
I've opted for #15 - thanks though @BurtHarris |
4 participants
Replace space-after-keywords with keyword-spacing
Adds eslint as a peer dependency
fixes #10