format: retain comments in import statements#142
Merged
robinheghan merged 10 commits intogren-lang:mainfrom Nov 26, 2022
Merged
format: retain comments in import statements#142robinheghan merged 10 commits intogren-lang:mainfrom
robinheghan merged 10 commits intogren-lang:mainfrom
Conversation
…ails to parse the input
Member
|
Code looks good to me. Ready to merge? |
Contributor
Author
|
Yep, ready!
…On Fri, Nov 25, 2022, 12:42 AM Robin Heggelund Hansen < ***@***.***> wrote:
Code looks good to me. Ready to merge?
—
Reply to this email directly, view it on GitHub
<#142 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAJRXKUNV54J3HLUCNICDWKB3XBANCNFSM6AAAAAAQ333RQE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importkeyword and module nameaskeywordexposingkeywordaskeyword and module alias nameexposingkeywordexposingkeyword and exposing listingNot included in this PR (will be in a future PR):
Note: After thinking through how trailing comments will want to be attached to AST nodes in other places, the approach taken here of adding a
Space.chompIndentedAtLeastseems like the best approach and also seems to be the simplest and most flexible of the different options I came up with.