internal: fix broken npm/deno deployments#4796
Merged
Merged
Conversation
deploy jobs became stale on 2024-06-2 when the repository stopped using main as the default branch and moved the active default line to 16.x.x (graphql#4131). Issue graphql#4766 notes that the jobs were still gated on refs/heads/main. This PR gates the npm and deno branch deployments on 17.x.x => that branch is about to become the new default.
PR graphql#3491 copied `github.event.workflow_run.head_sha` into a workflow that runs on push events. Issue graphql#4766 notes that this leaves the generated npm and deno deployment commit messages without the source commit hash. Use `github.sha` instead of `github.event.workflow_run.head_sha` so those deployment commits identify the commit that produced their artifacts.
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
yaacovCR
added a commit
that referenced
this pull request
Jun 15, 2026
## v17.0.0 (2026-06-15) #### New Feature 🚀 * [#4819](#4819) feat: graduate directives on directives ([@yaacovCR](https://github.com/yaacovCR)) #### Bug Fix 🐞 * [#4799](#4799) fix: raise request error on invalid fragment variables ([@yaacovCR](https://github.com/yaacovCR)) * [#4800](#4800) fix: apply directives when SDL contains type definitions and extensions with directives ([@yaacovCR](https://github.com/yaacovCR)) * [#4564](#4564) OneOf Inhabitability ([@jbellenger](https://github.com/jbellenger)) * [#4814](#4814) fix(KnownDirectivesRule): locations for input field arguments in extensions ([@yaacovCR](https://github.com/yaacovCR)) * [#4726](#4726) feat(validation): reject directive definition cycles ([@yaacovCR](https://github.com/yaacovCR)) * [#4815](#4815) Revert "feat(validation): reject directive definition cycles (#4726)" ([@yaacovCR](https://github.com/yaacovCR)) #### Docs 📝 <details> <summary> 11 PRs were merged </summary> * [#4790](#4790) docs: minor diagnostics doc comment improvements ([@yaacovCR](https://github.com/yaacovCR)) * [#4791](#4791) fix: docs: polish diagnostics comments further ([@yaacovCR](https://github.com/yaacovCR)) * [#4793](#4793) docs: further improve general execution and tracing docs ([@yaacovCR](https://github.com/yaacovCR)) * [#4802](#4802) docs: correct extension field comments - v17 ([@yaacovCR](https://github.com/yaacovCR)) * [#4805](#4805) docs: publish fixed extensions comments ([@yaacovCR](https://github.com/yaacovCR)) * [#4807](#4807) docs: add prettier for jsdoc examples ([@yaacovCR](https://github.com/yaacovCR)) * [#4435](#4435) Subscriptions docs suggestions ([@Urigo](https://github.com/Urigo)) * [#4811](#4811) docs: fix a few indentations inside string literals ([@yaacovCR](https://github.com/yaacovCR)) * [#4813](#4813) internal: docs update ([@yaacovCR](https://github.com/yaacovCR)) * [#4820](#4820) docs: document `@experimental_disableErrorPropagation` ([@yaacovCR](https://github.com/yaacovCR)) * [#4817](#4817) docs: post 17.rc-0 update ([@yaacovCR](https://github.com/yaacovCR)) </details> #### Polish 💅 <details> <summary> 2 PRs were merged </summary> * [#4809](#4809) internal: use prettier for non-generated website files ([@yaacovCR](https://github.com/yaacovCR)) * [#4812](#4812) polish: fix stream test cases ([@yaacovCR](https://github.com/yaacovCR)) </details> #### Internal 🏠 <details> <summary> 6 PRs were merged </summary> * [#4795](#4795) chore: move website publishing from 16.x.x to 17.x.x ([@yaacovCR](https://github.com/yaacovCR)) * [#4796](#4796) internal: fix broken npm/deno deployments ([@yaacovCR](https://github.com/yaacovCR)) * [#4797](#4797) ci: update GitHub Actions versions ([@yaacovCR](https://github.com/yaacovCR)) * [#4806](#4806) internal: update frontmatter ([@yaacovCR](https://github.com/yaacovCR)) * [#4808](#4808) intenral: fix ci badge ([@yaacovCR](https://github.com/yaacovCR)) * [#4810](#4810) internal: add prettier:examples to lint-staged ([@yaacovCR](https://github.com/yaacovCR)) </details> #### Committers: 3 * James Bellenger([@jbellenger](https://github.com/jbellenger)) * Uri Goldshtein([@Urigo](https://github.com/Urigo)) * Yaacov Rydzinski ([@yaacovCR](https://github.com/yaacovCR))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy jobs became stale on 2024-06-2 when the repository stopped using main as the default branch and moved the active default line to 16.x.x (#4131).
Issue #4766 notes that the jobs were still gated on refs/heads/main.
This PR gates the npm and deno branch deployments on 17.x.x => that branch is about to become the new default.
PR #3491 copied
github.event.workflow_run.head_shainto a workflow that runs on push events. Issue #4766 notes that this leaves the generated npm and deno deployment commit messages without the source commit hash.Use
github.shainstead ofgithub.event.workflow_run.head_shaso those deployment commits identify the commit that produced their artifacts.