Improve description for @oneOf directive#3937
Conversation
Follow up from #3513. I think it is fine for the spec text in graphql/graphql-spec#825 to refer to `OneOf Input Object`, as the spec explains what that is in another section. In a directive definition, that explanation by itself does not make much sense without prior knowledge.
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @spawnia, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
left a comment
yaacovCR
left a comment
There was a problem hiding this comment.
does it work better with the "the" article?
The current wording (after the latest edits) is acceptable, but it has the bracketing problem: The original wording was clearer in my opinion. That said, happy to see it merged either way. |
This comment has been minimized.
This comment has been minimized.
@benjie The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
|
Example of using this can be found here: graphql/graphql-spec#825 (comment) |
4 participants
Follow up from #3513.
I think it is fine for the spec text in graphql/graphql-spec#825 to refer to
OneOf Input Object, as the spec explains what that is in another section. In a directive definition, that explanation by itself does not make much sense without prior knowledge.Channeling the RFC champion @benjie.