Repository navigation
test(observability): fix EventFilters compile errors in merge_integration tests - #79
Merged
Merged
Conversation
… in merge_integration tests
The hide_bots filter field was added to EventFilters in the previous
commit but the integration test file's 5 EventFilters{} initializers
weren't updated, causing E0063 missing-field errors. Field set to None
preserves the existing test behavior (no bot filtering).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hide_botsfilter addition toEventFilters(crates/temps-observability/src/filters.rs) bumped the struct from 8 to 9 fields, but the 5 struct-literalEventFilters { ... }constructors incrates/temps-observability/tests/merge_integration.rswere left at 8 fields, producing 5E0063: missing field hide_botserrors undercargo clippy --all-targets.hide_bots: Noneon all 5 sites to preserve the existing test behavior (no bot filtering).cargo clippy --workspace --lib --all-targets --no-deps -- -D warningsagainstmain. After the fix: 0 errors, 0 real warnings.Test plan
cargo clippy --workspace --lib --all-targets --no-deps -- -D warningspassescargo test --test merge_integration -p temps-observabilitycompiles (Docker required for the tests themselves to run)