Repository navigation
fix(logs,storage): runtime logs overhaul + storage UI polish - #78
Merged
Merged
Conversation
…ty) + storage UI polish
Both reverse-comparator sort_by calls in archive_search rewritten as sort_by_key with std::cmp::Reverse. Behavior identical; clippy is happy under -D warnings (which CI uses).
…ocker secrets path
- Gate process_git_push_event on the merged project+environment automatic_deploy flag so pushes no longer deploy when the user has disabled deploy-on-push. Adds is_automatic_deploy_enabled helper with merge semantics and 6 unit tests covering each project/env combination. - Migrate Observe page from hardcoded zinc-* classes to semantic theme tokens (bg-background, text-foreground, border-border, text-muted-foreground, bg-card) for proper light/dark theming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles a stack of fixes and UX work for the runtime log viewers (Live + History) plus a small Storage UI polish. None of the pieces depend on each other, but they ship together because the user-facing change is "log viewers are fixed and feel right."
Backend (
crates/temps-log-aggregator)next_cursorbut the search service ignoredfilter.cursoron the way back in, so chevrons returned the same first page. Now: cursor is parsed, narrows effectiveend_time, lines strictly older than the cursor timestamp are returned with no overlap.BinaryHeapof sizepage_size+1. O(N log K) time, O(K) memory regardless of total matches.total_scannedsemantics fixed. Now counts only matches that pass time + level + service + text filters, not raw bytes read from chunks.test_search_logs_with_pagination,test_search_logs_returns_chronological_order,test_search_logs_wider_window_returns_more_recent_logs).History viewer (
web/src/components/runtime-logs/history-log-viewer.tsx)pageSize200 → 500.DateRangePicker(HH:MM precision). Seeded with the previous preset for smooth handoff.MAX_FULLTEXT_HOURScap).Live viewer (
web/src/components/runtime-logs/log-viewer.tsx)LIVE_FLUSH_MIN_GAP_MS = 33.prefers-reduced-motion.~Y lps) with asampledchip whenlps >= 60./api/logs/searchevery N seconds withpage_size=500, replaces the visible buffer with the snapshot. Fires immediately on entry. "Refresh now" triggers an immediate poll.h-[calc(100vh-280px)]so the rope fills the viewport.estimateLineHeightupdated to match.Command palette (
web/src/components/command/CommandPalette.tsx)Three "Logs"-flavored entries (
Logs,Log History,Request Logs) all rendered withScrollText. Now distinct:ScrollTextfor live runtime logs,Historyfor the History deep-link,Networkfor HTTP request logs.Storage UI polish (bundled per request)
Storage.tsx— "Storage" → "Databases" everywhere user-facing; compact CPU/memory cell on running services in the list.ServiceResourcesPanel.tsx— tighter horizontal layout per cluster member, live-indicator dot.EditResourceLimitsDialog.tsx— swap input now means "extra swap above memory" rather than Docker's rawmemory_swaptotal. UI translation is done at submit time; API contract unchanged.Test plan
cargo test --lib -p temps-log-aggregator test_search_logs— 8 passed (including the 3 new regression tests).bun run build(web) — clean./api/logs/search:Risk and rollout
<ts_millis>:<chunk_uuid>) but the semantics of "next page" inverted to "older lines." Existing UIs holding stale cursors get older logs instead of duplicates — strictly safer.