Skip to content

Improve timeout in WriteControl#944

Merged
AlexVulaj merged 4 commits into
mainfrom
unknown repository
Aug 4, 2024
Merged

Improve timeout in WriteControl#944
AlexVulaj merged 4 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jun 23, 2024

Copy link
Copy Markdown

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

This PR restores two useful PRs that were lost in the rollback.

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

rfyiamcool and others added 3 commits June 23, 2024 15:48
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
A zero value for the Conn.WriteControl deadline specifies no timeout,
but the feature was implemented as a very long timeout (1000 hours).
This PR updates the code to use no timeout when the deadline is zero.

See the discussion in #895 for more details.
@AlexVulaj AlexVulaj merged commit 5e00238 into gorilla:main Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants