-
Notifications
You must be signed in to change notification settings - Fork 120
fix: [#312] orm connection is not working #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package gorm | ||
|
|
||
| import ( | ||
| ormcontract "github.com/goravel/framework/contracts/database/orm" | ||
| ) | ||
|
|
||
| type Conditions struct { | ||
| distinct []any | ||
| group string | ||
| having *Having | ||
| join []Join | ||
| limit *int | ||
| lockForUpdate bool | ||
| model any | ||
| offset *int | ||
| omit []string | ||
| order []any | ||
| scopes []func(ormcontract.Query) ormcontract.Query | ||
| selectColumns *Select | ||
| sharedLock bool | ||
| table *Table | ||
| where []Where | ||
| with []With | ||
| withoutEvents bool | ||
| withTrashed bool | ||
| } | ||
|
|
||
| type Having struct { | ||
| query any | ||
| args []any | ||
| } | ||
|
|
||
| type Join struct { | ||
| query string | ||
| args []any | ||
| } | ||
|
|
||
| type Select struct { | ||
| query any | ||
| args []any | ||
| } | ||
|
|
||
| type Table struct { | ||
| name string | ||
| args []any | ||
| } | ||
|
|
||
| type Where struct { | ||
| query any | ||
| args []any | ||
| or bool | ||
| } | ||
|
|
||
| type With struct { | ||
| query string | ||
| args []any | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no changes for this file, just order the methods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solve the problem: The conditions will be chaotic when switching connections through the old logic.
Before, the
Wheremethod, etc. calls the Gorm method directly and gets a new Gorm instance.Now, the conditions will be saved in
Conditions, and will be built when calling a final method, like:Get.After this change, we can control the conditions and the Gorm instance more freely.