feat: support cache maintenance mode driver - #1481
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
- Coverage 69.42% 69.39% -0.04%
==========================================
Files 376 377 +1
Lines 29902 30190 +288
==========================================
+ Hits 20760 20950 +190
- Misses 8182 8258 +76
- Partials 960 982 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
goravel-coder
commented
Jun 9, 2026
goravel-coder
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed the maintenance cache driver change and found one concurrency issue to fix.
hwbrzzl
reviewed
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR #1198 introduced file-backed up/down maintenance mode, which requires running the command on each server. A cache-backed driver lets applications share the same maintenance payload through an existing cache store while preserving the current file behavior by default.
With this configuration, running
go run . artisan downorgo run . artisan upon one server updates the maintenance state for every server using that cache store. The middleware now resolves storage, cache, config, and hash throughhttp.App.Make*()like the other HTTP middleware, which makes it consistent with container-backed dependencies and easier to test.