Address feedback on gRPC multiple StatsHandler support - #1311
Closed
krishankumar01 with Copilot wants to merge 1 commit into
Closed
Address feedback on gRPC multiple StatsHandler support#1311krishankumar01 with Copilot wants to merge 1 commit into
krishankumar01 with Copilot wants to merge 1 commit into
Conversation
1 task
Copilot
AI
changed the title
[WIP] Update gRPC telemetry instrumentation implementation
Address feedback on gRPC multiple StatsHandler support
Dec 22, 2025
Copilot stopped work on behalf of
krishankumar01 due to an error
December 22, 2025 21:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies that gRPC now supports multiple StatsHandlers natively - all registered handlers are invoked, not just the last one.
Context
The bot reviewer flagged the loop registering multiple stats handlers in
grpc/application.go:161-166, claiming only the last handler would take effect. This was based on outdated gRPC behavior.Resolution
No code changes required. Modern gRPC versions support multiple
grpc.StatsHandler()options - each handler is added to an internal list and all are invoked on RPC events. The current implementation correctly registers all telemetry handlers.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.