test: install goravel/slack and add Slack notification tests - #145
Open
goravel-coder wants to merge 5 commits into
Open
test: install goravel/slack and add Slack notification tests#145goravel-coder wants to merge 5 commits into
goravel-coder wants to merge 5 commits into
Conversation
hwbrzzl
force-pushed
the
bowen/install-slack-tests
branch
from
August 21, 2026 09:23
5539669 to
ab940e1
Compare
hwbrzzl
reviewed
Aug 21, 2026
added 3 commits
August 21, 2026 17:40
hwbrzzl
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/goravel/slackpackage, exposing aslacknotification channel configured viaSLACK_BOT_TOKEN/SLACK_CHANNEL, with the target channel read through the app config (slack.channel) so.envvalues are honored.Why
The example app previously had no Slack notification channel:
facades.Notification().Channel("slack")resolved to nil and Slack delivery couldn't be demonstrated. This change installs and registers thegithub.com/goravel/slackpackage so notifications can be routed to a real Slack workspace, and adds tests proving the channel is registered, text and rich messages are delivered, and the package can be cleanly installed/uninstalled.The target channel is read through
facades.Config().GetString("slack.channel")(backed bySLACK_CHANNEL) rather thanos.Getenv, so a channel set in.envis respected and the same source is used across the suite. The live-send assertions now include the channel in their error message, and feature CI passesSLACK_BOT_TOKEN/SLACK_CHANNELthrough as secrets.