feat: add disabled_runners config and tests - #127
Merged
Conversation
- Add disabled_runners config key to config/app.go with runner signature docs - Add BootstrapRunnerList + WithRunners hook to bootstrap/app.go - Add integration tests verifying runner enable/disable via disabled_runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
disabled_runnersconfiguration option documented in the v1.18 upgrade guide and integration tests that verify runner enable/disable behavior using a custom tracking runner.Changes
disabled_runnersconfig key with runner signature reference in commentsBootstrapRunnerListvariable and.WithRunners()hook enabling custom runner registration for teststrackerRunnerthat records whetherRun()was calledTest coverage
RunnerStartsWhenNotDisabledRunnerSkippedWhenDisabledWildcardSkipsAll"*"pattern prevents all custom runnersNamespaceWildcard"test:*"namespace wildcard worksSelectiveDisableRestoreEnablesRunnerWhy
The v1.18 framework introduced
app.disabled_runnersallowing users to selectively skip runners (HTTP, gRPC, queue, scheduler, telemetry) via config. The example project should demonstrate this feature.