feat: test OTLP exporter TLS end to end by krishankumar01 · Pull Request #119 · goravel/example

krishankumar01 · 2026-06-08T18:18:07Z

📑 Description

Tests the OTLP exporter TLS config from goravel/framework#1475 end to end.

New otel-collector-tls compose service: OTLP over TLS on :4319 (behind the tls compose profile), exporting to the same Jaeger/Prometheus/Loki backends as the existing collector.
TestTelemetryTLSTestSuite generates a CA and server certificate at setup, points the exporters at https://localhost:4319/v1/<signal> with insecure=false and tls.ca, and asserts traces, metrics, and logs arrive.
Regenerates config/telemetry.go with package:install Telemetry and pins the framework to current master, which also fixes the TestInstallAndUninstall* failures on master CI.
New tests/telemetry kit shared by both telemetry suites: compose lifecycle with readiness probes instead of sleeps, polling backend assertions (AwaitTraces/AwaitMetric/AwaitLogs), config override/restore scope, and teardown owned by TestMain. Each suite claims a unique telemetry.service.name. Conventions documented in AGENTS.md.

Manual telemetry usage examples (custom spans, metrics, propagation, per the v1.18 docs) will follow in a separate PR as a consumer of this kit.

✅ Checks

Added test cases for my code

Add tls ca/cert/key knobs to the trace, metric, and log OTLP exporters, mirroring the framework stub, so the example can target a TLS-enabled collector (https:// endpoint with insecure=false).

Copilot

Pull request overview

This PR extends the example app’s telemetry configuration to allow OTLP trace/metric/log exporters to be configured for TLS by adding tls (ca/cert/key) file-path knobs in config/telemetry.go, aligning the example’s config surface with the framework’s expected options while keeping default plaintext behavior unchanged.

Changes:

Add tls map support to the OTLP trace exporter configuration (CA + optional mTLS client cert/key).
Add tls map support to the OTLP metric exporter configuration (CA + optional mTLS client cert/key).
Add tls map support to the OTLP log exporter configuration (CA + optional mTLS client cert/key).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…th framework master

…he fix

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

hwbrzzl

LGTM, please consider the Copilot comments.

hwbrzzl · 2026-06-12T09:43:42Z

Could you add some examples based on https://github.com/goravel/docs/pull/192/changes#diff-2869e2731d8a93f0fb13dc4cd219545d1b4cdf8d12c79d8ea7012690f2b3d6ff? It's good to show how to use the telemetry module. It's fine to add them in another PR or this one.

krishankumar01 · 2026-06-12T10:00:05Z

Could you add some examples based on https://github.com/goravel/docs/pull/192/changes#diff-2869e2731d8a93f0fb13dc4cd219545d1b4cdf8d12c79d8ea7012690f2b3d6ff? It's good to show how to use the telemetry module. It's fine to add them in another PR or this one.

Will raise a separate PR for this

Copilot

Pull request overview

Copilot reviewed 14 out of 16 changed files in this pull request and generated no new comments.

hwbrzzl

LGTM

…eak it

Copilot

Pull request overview

Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.

hwbrzzl

LGTM

feat: expose OTLP exporter TLS config in telemetry

4b8cd0d

Add tls ca/cert/key knobs to the trace, metric, and log OTLP exporters, mirroring the framework stub, so the example can target a TLS-enabled collector (https:// endpoint with insecure=false).

Copilot AI review requested due to automatic review settings June 8, 2026 18:18

krishankumar01 requested a review from a team as a code owner June 8, 2026 18:18

Copilot started reviewing on behalf of krishankumar01 June 8, 2026 18:18 View session

Copilot AI reviewed Jun 8, 2026

View reviewed changes

Comment thread config/telemetry.go Outdated

Comment thread config/telemetry.go Outdated

Comment thread config/telemetry.go Outdated

test: cover OTLP exporter TLS end to end and sync telemetry config wi…

c684e33

…th framework master

krishankumar01 changed the title ~~feat: expose OTLP exporter TLS config in telemetry~~ feat: cover OTLP exporter TLS end to end and sync telemetry config with framework master Jun 9, 2026

test: assert logs over TLS and pin framework with the log handler cac…

5bb73cf

…he fix

Copilot AI review requested due to automatic review settings June 9, 2026 21:00

Copilot started reviewing on behalf of krishankumar01 June 9, 2026 21:00 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread docker-compose.yml

krishankumar01 changed the title ~~feat: cover OTLP exporter TLS end to end and sync telemetry config with framework master~~ feat: test OTLP exporter TLS end to end Jun 9, 2026

krishankumar01 added 2 commits June 10, 2026 13:40

chore: pin framework to master with the log handler cache fix

b6ef06c

test: keep the last session cookie after login rotation

8ae0c8f

Copilot AI review requested due to automatic review settings June 10, 2026 09:06

Copilot started reviewing on behalf of krishankumar01 June 10, 2026 09:06 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Comment thread tests/feature/telemetry_tls_test.go Outdated

Comment thread tests/feature/telemetry_tls_test.go Outdated

krishankumar01 added 2 commits June 11, 2026 20:39

fix: bump goravel/gin and drop duplicate-cookie workaround

8090eef

fix: gate TLS collector behind a compose profile and clean up test certs

883f1fc

Copilot AI review requested due to automatic review settings June 11, 2026 16:02

Copilot started reviewing on behalf of krishankumar01 June 11, 2026 16:03 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread tests/feature/telemetry_tls_test.go

Comment thread tests/feature/telemetry_tls_test.go Outdated

Comment thread tests/feature/telemetry_tls_test.go Outdated

hwbrzzl reviewed Jun 12, 2026

View reviewed changes

test: add tests/telemetry kit and refactor telemetry suites

838caad

test: fix errcheck findings in telemetry kit

e3dc127

Copilot AI review requested due to automatic review settings June 12, 2026 10:13

Copilot started reviewing on behalf of krishankumar01 June 12, 2026 10:13 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

revert http client base_url derivation

3e96829

hwbrzzl previously approved these changes Jun 13, 2026

View reviewed changes

test: restore telemetry config via Cleanup so setup failures cannot l…

f5a6744

…eak it

krishankumar01 dismissed hwbrzzl’s stale review via f5a6744 June 13, 2026 02:21

Copilot AI review requested due to automatic review settings June 13, 2026 02:21

Copilot started reviewing on behalf of krishankumar01 June 13, 2026 02:22 View session

Copilot AI reviewed Jun 13, 2026

View reviewed changes

Comment thread tests/telemetry/stack.go Outdated

Comment thread tests/telemetry/query_test.go Outdated

test: parameterize poll timings and enable tls profile on stack up

b7ae4a6

hwbrzzl approved these changes Jun 13, 2026

View reviewed changes

krishankumar01 merged commit b20e6e4 into master Jun 13, 2026
4 checks passed

krishankumar01 deleted the kkumar-gcc/example-tls branch June 13, 2026 08:29

Uh oh!

Conversation

krishankumar01 commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

✅ Checks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

hwbrzzl commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishankumar01 commented Jun 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krishankumar01 commented Jun 8, 2026 •

edited

Loading

hwbrzzl commented Jun 12, 2026 •

edited

Loading