chore(deps): update opentelemetry-python monorepo to v1.40.0#838
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the OpenTelemetry Python monorepo dependencies, specifically Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates opentelemetry-api and opentelemetry-sdk to version 1.40.0. While reviewing the changes, I noticed that the test configurations in noxfile.py use outdated, pinned versions of these dependencies (1.27.0). This means the tests are not validating the effects of this upgrade. I've added a comment to address this to ensure the project's stability and correctness after the update.
Note: Security Review has been skipped due to the limited scope of the PR.
| opentelemetry-api==1.38.0 \ | ||
| --hash=sha256:2891b0197f47124454ab9f0cf58f3be33faca394457ac3e09daba13ff50aa582 \ | ||
| --hash=sha256:f4c193b5e8acb0912b06ac5b16321908dd0843d75049c091487322284a3eea12 | ||
| opentelemetry-api==1.40.0 \ |
There was a problem hiding this comment.
The opentelemetry-api and opentelemetry-sdk dependencies are being updated to 1.40.0, but the test environments defined in noxfile.py are hardcoded to use version 1.27.0 for both unit and system tests.
This discrepancy means that the tests are not running against the new versions of these dependencies, and any potential regressions or issues introduced by this upgrade could be missed.
To ensure the stability of the project, please update the pinned versions in noxfile.py to match the versions in this pull request.
For example, in noxfile.py:
# in system() session
session.install("opentelemetry-api==1.40.0")
session.install("opentelemetry-sdk==1.40.0")
# in unit() session
session.install("opentelemetry-api==1.40.0")
session.install("opentelemetry-sdk==1.40.0")This will ensure that your test suite properly validates the updated dependencies.
There was a problem hiding this comment.
Removed the version restrictions for OpenTelemetry in the tests.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
==1.38.0→==1.40.0==1.38.0→==1.40.0Release Notes
open-telemetry/opentelemetry-python (opentelemetry-api)
v1.40.0Compare Source
opentelemetry-sdk: deprecateLoggingHandlerin favor ofopentelemetry-instrumentation-logging, seeopentelemetry-instrumentation-loggingdocumentation(#4919)
opentelemetry-sdk: Clarify log processor error handling expectations in documentation(#4915)
(#4941)
(#4926)
opentelemetry-sdk: Drop unused Jaeger exporter environment variables (exporter removed in 1.22.0)(#4918)
opentelemetry-sdk: Clarify timeout units in environment variable documentation(#4906)
opentelemetry-exporter-otlp-proto-grpc: Fix re-initialization of gRPC channel on UNAVAILABLE error(#4825)
opentelemetry-exporter-prometheus: Fix duplicate HELP/TYPE declarations for metrics with different label sets(#4868)
OTEL_EXPERIMENTAL_RESOURCE_DETECTORSto*(#4819)
opentelemetry-sdk: Fix the type hint of the_metrics_dataproperty to allowNone(#4837).
(#4840)
(#4798)
(#4847)
(#4806)
SimpleLogRecordProcessor.on_emit,(#4799) and (#4867).
(#4880)
(#4609)
(#4882)
(#4862)
opentelemetry-exporter-otlp-proto-http: fix retry logic and error handling for connection failures in trace, metric, and log exporters(#4709)
opentelemetry-sdk: avoid RuntimeError during iteration of view instrument match dictionary in MetricReaderStorage.collect()(#4891)
(#4861)
opentelemetry-sdk: Fix instrument creation race condition(#4913)
(#4914)
opentelemetry-sdk: automatically generate configuration models using OTel config JSON schema(#4879)
v1.39.1: Version 1.39.1/0.60b1Compare Source
This is a patch release on the previous 1.39.0/0.60b0 release, fixing the issue(s) below.
v1.39.0Compare Source
opentelemetry-api: Convert objects of any type other than AnyValue in attributes to string to be exportable(#4808)
docs: Added sqlcommenter example
(#4734)
build: bump ruff to 0.14.1
(#4782)
Add
opentelemetry-exporter-credential-provider-gcpas an optional dependency toopentelemetry-exporter-otlp-proto-grpcand
opentelemetry-exporter-otlp-proto-http(#4760)
feat: implement on ending in span processor
(#4775)
semantic-conventions: Bump to 1.38.0
(#4791)
[BREAKING] Remove LogData and extend SDK LogRecord to have instrumentation scope
(#4676)
[BREAKING] Rename several classes from Log to LogRecord
(#4647)
Migration Guide:
LogDatahas been removed. Users should update their code as follows:For Log Exporters: Change from
Sequence[LogData]toSequence[ReadableLogRecord]For Log Processors: Use
ReadWriteLogRecordfor processing,ReadableLogRecordfor exportingAccessing log data: Use the same attributes on
ReadableLogRecord/ReadWriteLogRecordlog_record.log_record- The API LogRecord (contains body, severity, attributes, etc.)log_record.resource- The Resourcelog_record.instrumentation_scope- The InstrumentationScope (now included, was in LogData before)log_record.limits- The LogRecordLimitsMark the Events API/SDK as deprecated. The Logs API/SDK should be used instead, an event is now a
LogRecordwith theevent_namefield set(#4654).
Fix type checking for built-in metric exporters
(#4820)
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.