This repository was archived by the owner on Mar 2, 2026. It is now read-only.
fix: clean up resources on Watch close#1004
Merged
daniel-sanche merged 3 commits intomainfrom Jan 10, 2025
Merged
Conversation
product-auto-label
bot
added
the
api: firestore
gkevinzheng
approved these changes
Jan 7, 2025
cindy-peng
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #985
clears resources associated with the Watch class when calling close on an active instance
I opened googleapis/python-api-core#769 to address the memory leak in
api_core, but this change will address it for firestore while waiting for the upstream fix