This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Conversation
googlebot
added
the
cla: yes
plamut
added
do not merge
googlebot
added
the
cla: yes
|
|
plamut
commented
Feb 4, 2020
synth.py
Outdated
Comment on lines
+66
to
+67
| # we do not want override the custom noxfile with the generated one | ||
| os.remove(os.path.join(templated_files, "noxfile.py")) |
Contributor
Author
There was a problem hiding this comment.
Looking at CommonTemplates.py_library(), I suppose there is no better way of excluding a particular template file? Cannot manipulate the excludes list through kwargs...
plamut
removed
the
do not merge
plamut
added
the
type: process
plamut
force-pushed
the
repo-templates
branch
from
e5b24c5 to
6431098
Compare
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
busunkim96
reviewed
Feb 5, 2020
| templated_files = common.py_library(cov_level=100) | ||
| # we do not want to override the custom noxfile with the generated one | ||
| os.remove(os.path.join(templated_files, "noxfile.py")) | ||
| s.move(templated_files) |
Contributor
There was a problem hiding this comment.
You can add an excludes list to s.move.
s.move(templated_files, excludes=["noxfile.py"])
Contributor
Author
There was a problem hiding this comment.
Thanks!
Since it's a minor thing, I'll do it separately to not block the main PR of the repo migration.
busunkim96
approved these changes
Feb 5, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is "step 6 - Add Repo Templates" of the repo split procedure.
Warning - no.kokoro,.github/*, etc. files generated by the synthtool. There might be something missingUpdate: BigQuery's customnoxfile.pydid not include templated files, had to add that manually. Mind thatnoxfile.pyis still autogenerated and would get overridden every time synthtool is run - we probably want to exclude it?Alternatively, we could go back to the autogenerated noxfile. @tswast do yo maybe remember why BigQuery uses a custom noxfile in the first place?Update 2: Managed to hack around overriding the custom noxfile in this library.