googleapis · parthea · Oct 17, 2023 · Mar 14, 2022 · Mar 15, 2022 · Jun 14, 2022
diff --git a/google/api_core/bidi.py b/google/api_core/bidi.py
@@ -276,7 +276,11 @@ def open(self):
         request_generator = _RequestQueueGenerator(
             self._request_queue, initial_request=self._initial_request
         )
-        call = self._start_rpc(iter(request_generator), metadata=self._rpc_metadata)
+        try:
+            call = self._start_rpc(iter(request_generator), metadata=self._rpc_metadata)
+        except exceptions.GoogleAPICallError as exc:
+            self._on_call_done(exc)
     Note that error handling *must* be done by using the provided 
     ``bidi_rpc``'s ``add_done_callback``. This helper will automatically exit 
     whenever the RPC itself exits and will not provide any error details. 
 # Unlike the base class, we only execute the callbacks on a terminal 
 # error, not for errors that we can recover from. Note that grpc's 
 # "future" here is also a grpc.RpcError. 
 def wrap_errors(callable_): 
     """Wrap a gRPC callable and map :class:`grpc.RpcErrors` to friendly error 
     classes. 
     Errors raised by the gRPC callable are mapped to the appropriate 
     :class:`google.api_core.exceptions.GoogleAPICallError` subclasses. 
     The original `grpc.RpcError` (which is usually also a `grpc.Call`) is 
     available from the ``response`` property on the mapped exception. This 
     is useful for extracting metadata from the original error. 
     Note that error handling *must* be done by using the provided 
     ``bidi_rpc``'s ``add_done_callback``. This helper will automatically exit 
     whenever the RPC itself exits and will not provide any error details. 
 # Unlike the base class, we only execute the callbacks on a terminal 
 # error, not for errors that we can recover from. Note that grpc's 
 # "future" here is also a grpc.RpcError. 
 def wrap_errors(callable_): 
     """Wrap a gRPC callable and map :class:`grpc.RpcErrors` to friendly error 
     classes. 
  
     Errors raised by the gRPC callable are mapped to the appropriate 
     :class:`google.api_core.exceptions.GoogleAPICallError` subclasses. 
     The original `grpc.RpcError` (which is usually also a `grpc.Call`) is 
     available from the ``response`` property on the mapped exception. This 
     is useful for extracting metadata from the original error. 
+            raise
 
         request_generator.call = call
 

diff --git a/tests/unit/test_bidi.py b/tests/unit/test_bidi.py
@@ -804,6 +804,19 @@ def test_wake_on_error(self):
         while consumer.is_active:
             pass
 
+    def test_rpc_callback_fires_when_consumer_start_fails(self):
+        expected_exception = exceptions.InvalidArgument("test")
+        callback = mock.Mock(spec=["__call__"])
+
+        rpc, _ = make_rpc()
+        bidi_rpc = bidi.BidiRpc(rpc)
+        bidi_rpc.add_done_callback(callback)
+        bidi_rpc._start_rpc.side_effect = expected_exception
+
+        consumer = bidi.BackgroundConsumer(bidi_rpc, on_response=None)
+        consumer.start()
+        assert callback.call_args.args[0] == expected_exception
+
     def test_consumer_expected_error(self, caplog):
         caplog.set_level(logging.DEBUG)