Skip to content

feat: add preview MultipartUploadClient#createMultipartUpload#3356

Merged
BenWhitehead merged 21 commits into
staged-mpu-merge-trainfrom
mpu-feature-2
Nov 3, 2025
Merged

feat: add preview MultipartUploadClient#createMultipartUpload#3356
BenWhitehead merged 21 commits into
staged-mpu-merge-trainfrom
mpu-feature-2

Conversation

@ShreyasSinha

@ShreyasSinha ShreyasSinha commented Oct 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  1. Adding model classes for CreateMultipartUpload request and response.
  2. Setting Client for Multipart Upload.
  3. Introducing data class for ObjectLockMode https://cloud.google.com/storage/docs/object-lock
  4. Implemented Object parser for XML MPU.

Refer: #3348

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Oct 21, 2025
@ShreyasSinha ShreyasSinha changed the title Mpu feature 2 feat: Added API for CreateMultipartUpload. Oct 21, 2025
@ShreyasSinha ShreyasSinha changed the title feat: Added API for CreateMultipartUpload. feat: Adding API for CreateMultipartUpload. Oct 21, 2025
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Oct 21, 2025
@ShreyasSinha ShreyasSinha marked this pull request as ready for review October 21, 2025 18:46
@ShreyasSinha ShreyasSinha requested review from a team October 21, 2025 18:46
BenWhitehead
BenWhitehead requested changes Oct 21, 2025
View reviewed changes
Comment thread ...c/main/java/com/google/cloud/storage/multipartupload/model/CreateMultipartUploadRequest.java
Comment thread ...c/main/java/com/google/cloud/storage/multipartupload/model/CreateMultipartUploadRequest.java
Comment thread ...c/main/java/com/google/cloud/storage/multipartupload/model/CreateMultipartUploadRequest.java
Comment thread ...c/main/java/com/google/cloud/storage/multipartupload/model/CreateMultipartUploadRequest.java Outdated
Comment thread ...oud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/ObjectLockMode.java
Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadClientImpl.java Outdated
Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadClientImpl.java Outdated
Comment thread ...-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java Outdated
Comment thread google-cloud-storage/src/test/java/com/google/cloud/storage/MultipartUploadClientImplTest.java Outdated
Comment thread google-cloud-storage/src/test/java/com/google/cloud/storage/MultipartUploadClientImplTest.java Outdated
BenWhitehead
BenWhitehead requested changes Oct 22, 2025
View reviewed changes
Comment thread ...oud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/ObjectLockMode.java
Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/XmlObjectParser.java Outdated
Comment thread ...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java Outdated
Comment thread ...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java
Comment thread ...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java Outdated
Comment thread ...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java
BenWhitehead
BenWhitehead requested changes Oct 23, 2025
View reviewed changes
Comment thread ...-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java Outdated
Comment thread google-cloud-storage/pom.xml Outdated
Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadClientImpl.java Outdated
ShreyasSinha
ShreyasSinha commented Oct 24, 2025
View reviewed changes

@ShreyasSinha ShreyasSinha left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added refactoring changes in this PR only.

Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadClientImpl.java Outdated
Comment thread google-cloud-storage/pom.xml Outdated
@BenWhitehead

BenWhitehead commented Oct 24, 2025

Copy link
Copy Markdown
Collaborator

No more requested changes for this PR at this time, but we do have some followups later. Holding off merging for now.

@BenWhitehead BenWhitehead mentioned this pull request Oct 30, 2025
Merged
10 tasks
BenWhitehead
BenWhitehead approved these changes Oct 31, 2025
View reviewed changes

@BenWhitehead BenWhitehead left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for merge train

Base automatically changed from mpu-feature-1 to staged-mpu-merge-train November 3, 2025 21:06
@BenWhitehead BenWhitehead merged commit 33066b8 into staged-mpu-merge-train Nov 3, 2025
16 checks passed
@BenWhitehead BenWhitehead deleted the mpu-feature-2 branch November 3, 2025 21:11
@BenWhitehead BenWhitehead mentioned this pull request Nov 3, 2025
Closed
@BenWhitehead BenWhitehead changed the title feat: Adding API for CreateMultipartUpload. feat: add MultipartUploadClient#create Nov 3, 2025
@BenWhitehead BenWhitehead changed the title feat: add MultipartUploadClient#create feat: add MultipartUploadClient#createMultipartUpload Nov 3, 2025
@BenWhitehead BenWhitehead changed the title feat: add MultipartUploadClient#createMultipartUpload feat: add preview MultipartUploadClient#createMultipartUpload Nov 3, 2025
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha @BenWhitehead
chore: mpu client preview merge train
479ffee 
BEGIN_NESTED_COMMIT

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

END_NESTED_COMMIT

Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha @BenWhitehead
chore: mpu client preview merge train
7ad9fa4 
BEGIN_NESTED_COMMIT

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

END_NESTED_COMMIT

Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha @BenWhitehead
chore: mpu client preview merge train
160fa9a 
BEGIN_NESTED_COMMIT

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

END_NESTED_COMMIT

Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@release-please release-please Bot mentioned this pull request Oct 30, 2025
Merged
@BenWhitehead

BenWhitehead commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

merged to main in #3378

@louisnow louisnow mentioned this pull request Jan 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShreyasSinha @BenWhitehead