feat(storage): add support for signing URLs using token#9889
Merged
crwilcox merged 3 commits intogoogleapis:masterfrom Jan 30, 2020
Merged
Conversation
googlebot
added
the
cla: yes
HemangChothani
changed the title
Contributor
Author
|
@crwilcox system test failed due to |
Contributor
Author
|
@crwilcox PTAL |
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
approved these changes
Jan 28, 2020
crwilcox
added
kokoro:run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
HemangChothani
deleted the
Storage_add_support_signing_URLs_using_IAM_tokens
branch
This was referenced Jan 31, 2020
Closed
Closed
[CHANGE ME] Re-generated firestore to pick up changes in the API or client library generator.
#10291
Closed
This was referenced Feb 4, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
|
Hi guys Im pretty ignorant how to solve / report bugs. I found one with this added feature. I gonna try to solve next days (i hope). In this line https://github.com/q-logic/google-cloud-python/blob/f1f9e9ae6d0680d7864d3c771d82f7c9c795c246/storage/google/cloud/storage/_signing.py#L389 you are passing expiration as is sent but you have to use the convert function to put the value in a proper format otherwise the url is bad. |
|
SO far Im using it like this |
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* feat(storage): add support for signing URLs using token * feat(bigquery): add system tests for the feature * feat(storage): add iam dependency in nox file and cosmetic changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7627