Skip to content

fix(monitoring): make VPCSC env comparison case-insensitive #9564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 5 commits into from
Nov 6, 2019
Merged

fix(monitoring): make VPCSC env comparison case-insensitive #9564

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92634f7
Make VPCSC env comparison case-insensitive.
steinwaywhw Oct 29, 2019
c28e0ed
Update noxfile.py
steinwaywhw Oct 29, 2019
4722937
Update noxfile.py
steinwaywhw Oct 29, 2019
cee06dc
Update monitoring/noxfile.py
steinwaywhw Oct 31, 2019
649a9b8
Update monitoring/noxfile.py
steinwaywhw Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion monitoring/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ def system(session):
session.install("-e", ".")

# Additional setup for VPCSC system tests
if os.environ.get("GOOGLE_CLOUD_TESTS_IN_VPCSC") != "true":
in_vpc = os.environ.get("GOOGLE_CLOUD_TESTS_IN_VPCSC")
Comment thread
steinwaywhw marked this conversation as resolved.
Outdated
if not in_vpc or in_vpc.lower() != "true":
Comment thread
steinwaywhw marked this conversation as resolved.
Outdated
# Unset PROJECT_ID, since VPCSC system tests expect this to be a project
# within the VPCSC perimeter.
env = {
Expand Down