Skip to content

Implementing analyze sentiment method and helpers in language#2189

Merged
dhermes merged 3 commits intogoogleapis:masterfrom
dhermes:language-impl-5
Aug 26, 2016
Merged

Implementing analyze sentiment method and helpers in language#2189
dhermes merged 3 commits intogoogleapis:masterfrom
dhermes:language-impl-5

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 24, 2016 •
edited
Loading

NOTE: Has #2187 as diffbase.

tseaver
tseaver reviewed Aug 24, 2016
View reviewed changes
gcloud/language/sentiment.py

:type polarity: float
:param polarity: Polarity of the sentiment in the ``[-1.0, 1.0]`` range.
Larger numbers represent more positive sentiments.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Aug 24, 2016 •
edited
Loading

c70c471 looks fine, except for the (API-induced) confustion between polarity and magnitude. We may not be able to fix the conceptual issue, but maybe the docs have some words about the ideas?

e8b1b0f is fine.

6c4b6ef looks fine: the last assertion looks like it could be either too broad (to avoid flaky failures).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2016
@tseaver
Copy link
Contributor

tseaver commented Aug 25, 2016

LGTM once the docstring for sentiment includes a link to the concept docs.

@dhermes dhermes merged commit a3f6353 into googleapis:master Aug 26, 2016
@dhermes dhermes deleted the language-impl-5 branch August 26, 2016 20:04
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
parthea pushed a commit that referenced this pull request Mar 6, 2026
@chalmerlowe
ci: Update to the CI/CD pipeline via github workflow to help cut turn…
6872a0a 
…-around time (#2189)

Update to the CI/CD pipeline via github workflow to help cut turn-around time.

* added github workflow
* changed the number of pytest-xdist workers from "auto" to "8" (based on local tests and discussion with Tim, choosing auto sometimes takes longer to run than choosing a smaller number. I suspect this is partly because for small or short tests the overhead needed to setup a worker exceeds the time savings of having extra workers).
* modified numerous tests to explicitly include a project path to avoid an attempt to find the project by making an external call via the pydata-google-auth workflow (which opens an input and waits for response from the user that never comes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @tseaver @jerjou @daspecster @googlebot