Skip to content

Drop Python 2.6 on appveyor, install 'grpcio' unconditionally.#1882

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:1877-moar-appveyour-grpc-fixing
Jun 21, 2016
Merged

Drop Python 2.6 on appveyor, install 'grpcio' unconditionally.#1882
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:1877-moar-appveyour-grpc-fixing

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 21, 2016

grpcio 0.14.0 installs without errors on Python 3.4+.

See #1863, failures after merging #1877.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. testing labels Jun 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2016
@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016 •
edited
Loading

@tseaver, do you have appveyor hooked up to your github username? or if you want I can copy this branch to my repo and run it.

Update: Build running @ https://ci.appveyor.com/project/daspecster/gcloud-python-pjqjn

@tseaver tseaver merged commit 45a3b51 into googleapis:master Jun 21, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

Oops, I was out-of-sync and merged ahead of seeing your build finish.

@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016

Np, I have it building master now https://ci.appveyor.com/project/daspecster/gcloud-python-pjqjn

@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016

@tseaver lots of
ImportError: cannot import name timestamp_pb2
https://ci.appveyor.com/project/daspecster/gcloud-python-pjqjn/build/1.0.5.master/job/9yeww3g7vk6wvdcr#L543

@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016

A little different for py3,
https://ci.appveyor.com/project/daspecster/gcloud-python-pjqjn/build/1.0.5.master/job/0dn0nee07e773mc4#L194

@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

Ugh. I'm not sure what to say: somebody has hosed the google namespace package.

@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016

For windows specifically?

@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016

It's still that unbuilt egg error for py3 https://ci.appveyor.com/project/daspecster/gcloud-python-pjqjn/build/1.0.5.master/job/0dn0nee07e773mc4#L149

And yeah for py2 it can't import timestamp_pb2 from google.protobuf.
https://ci.appveyor.com/project/daspecster/gcloud-python-pjqjn/build/1.0.5.master/job/f8l9c4aixytmd4m0#L551

@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016

Could try and switching protobuf == 3.0.0b2 from 3.0.0b3?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

Maybe we should revert this PR (or at least the bit which globally installs grpcio) and just leave Appveyor borken until a fix is released for grpc/grpc#6939.

@daspecster
Copy link
Contributor

daspecster commented Jun 21, 2016

Wouldn't we want it this way once grpc/grpc#6939 is resolved?

@tseaver tseaver deleted the 1877-moar-appveyour-grpc-fixing branch June 27, 2016 15:04
@tseaver tseaver mentioned this pull request Jun 29, 2016
Merged
parthea pushed a commit that referenced this pull request Mar 6, 2026
@renovate-bot @gcf-owl-bot
@chalmerlowe @Linchin
chore(deps): update all dependencies (#1882)
5959471 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* pin pycparser==2.21 for python 3.7

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @daspecster @dhermes @googlebot