Skip to content

chore(crc32c): set up release scripts - #18400

Merged
ohmayr merged 16 commits into
mainfrom
fix_crc32c_release_config
Sep 18, 2026
Merged

ohmayr merged 16 commits into
mainfrom
fix_crc32c_release_config

Conversation

@daniel-sanche

@daniel-sanche daniel-sanche commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

This PR:

  • restores the release scripts for crc32c that were removed as part of the monorepo migration
  • adds extra validation to make sure sdist-only releases will not accidentally be published
  • adds a release block on crc32c, until we add matching backend configs
  • move the supported versions list into a centralized location for build scripts, instead of having each script encode it separately

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release and build configurations for the google-crc32c package across Linux, macOS, and Windows. It introduces a single source of truth for supported Python versions (python_versions.yaml), ensures the pure-Python fallback is disabled during Kokoro CI builds, adds twine check validation for built wheels, and updates test scripts to output JUnit XML logs. The reviewer feedback highlights opportunities to improve the robustness of the build scripts by replacing fragile version string slicing with more reliable parsing methods (like cut or for /f) and replacing hardcoded Python 3.12 references with dynamic py -3 calls.

Comment thread packages/google-crc32c/scripts/manylinux/build_on_centos.sh
Comment thread packages/google-crc32c/scripts/osx/build.sh Outdated
Comment thread packages/google-crc32c/scripts/windows/build.bat Outdated
Comment thread packages/google-crc32c/scripts/windows/build.bat Outdated
Comment thread .kokoro/release/crc32c/release-windows-wheel.bat Outdated
Comment thread .kokoro/release/crc32c/release-windows-wheel.bat Outdated
Comment thread .kokoro/release/crc32c/release-windows-wheel.bat Outdated
@ohmayr
ohmayr added this pull request to stack #18415 September 17, 2026 22:27
@daniel-sanche daniel-sanche changed the title [DRAFT] chore(crc32c): set up release scripts chore(crc32c): set up release scripts Sep 18, 2026
@daniel-sanche
daniel-sanche marked this pull request as ready for review September 18, 2026 00:04
@daniel-sanche
daniel-sanche requested review from a team as code owners September 18, 2026 00:05
@ohmayr
ohmayr force-pushed the fix_crc32c_release_config branch from b7fcebd to 528a9ab Compare September 18, 2026 00:08
@ohmayr ohmayr self-assigned this Sep 18, 2026
@ohmayr
ohmayr force-pushed the fix_crc32c_release_config branch from 528a9ab to 49d95f1 Compare September 18, 2026 15:32
@ohmayr
ohmayr merged commit 6389ee6 into main Sep 18, 2026
146 of 242 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants