chore(crc32c): set up release scripts - #18400
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the release and build configurations for the google-crc32c package across Linux, macOS, and Windows. It introduces a single source of truth for supported Python versions (python_versions.yaml), ensures the pure-Python fallback is disabled during Kokoro CI builds, adds twine check validation for built wheels, and updates test scripts to output JUnit XML logs. The reviewer feedback highlights opportunities to improve the robustness of the build scripts by replacing fragile version string slicing with more reliable parsing methods (like cut or for /f) and replacing hardcoded Python 3.12 references with dynamic py -3 calls.
ohmayr
added this pull request to stack #18415
September 17, 2026 22:27
daniel-sanche
marked this pull request as ready for review
September 18, 2026 00:04
ohmayr
force-pushed
the
fix_crc32c_release_config
branch
from
September 18, 2026 00:08
b7fcebd to
528a9ab
Compare
ohmayr
force-pushed
the
fix_crc32c_release_config
branch
from
September 18, 2026 15:32
528a9ab to
49d95f1
Compare
ohmayr
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: