Make synchronous query snippets testable#1836
Merged
tseaver merged 5 commits intogoogleapis:masterfrom Jul 14, 2016
tseaver:bigquery-testable_sync_query_snippets
Merged
Make synchronous query snippets testable#1836tseaver merged 5 commits intogoogleapis:masterfrom tseaver:bigquery-testable_sync_query_snippets
tseaver merged 5 commits intogoogleapis:masterfrom
tseaver:bigquery-testable_sync_query_snippets
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
Rebased after merging #1833 to |
| >>> from gcloud import bigquery | ||
| >>> client = bigquery.Client() | ||
|
|
||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Can we squash this before merging? |
|
|
||
| @snippet | ||
| def client_list_datasets(client, to_delete): # pylint: disable=unused-argument | ||
| def client_list_datasets(client, _): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM, I would still squash but whatever you think. |
Contributor
Author
|
@daspecster I rebased away the first two net-noop commits. I will merge when Travis passes. |
This was referenced Aug 3, 2016
Closed
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
) * fix: update error logging when converting to pyarrow column fails * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * resolve merge conflict * resolve missing dependency * more tweaks to constraints and requirements re pyarrow * even more tweaks to constraints and requirements re pyarrow * a few more tweaks to constraints and requirements re pyarrow * resolves issue of pyarrow not installing * fix linting issue * update linting and conditionals * update linting and mypy comments * quick tags on several coverage issues related to imports * adds pragma to exception * updates test suite with new test and makes msg explicit * temporarily adding timing code * additional timing test mods * add pragmas to account for several tests * cleaned up some test code * cleaned up some test code * Update a test to include column datatype * update to pytest.raises command * Update tests/unit/test__pandas_helpers.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removed unused variable 'e' --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #1833 as a base.